3 ms·
To be fair, some people are just pedantic. Just because you are the reviewer doesn’t mean things have to be done exactly the way you say. If I never accept any
by Aeolun 4y ago
To be fair, some people are just pedantic. Just because you are the reviewer doesn’t mean things have to be done exactly the way you say.
If I never accept anything from more junior people because it isn’t perfect, how are they ever going to stay motivated?
I aim for one or at most two rounds of review, because anything else is just depressing.
- cramjabsyn 4y agoEhhh far from perfection, more like “please use the native feature that handles this in 2 LOC instead of shelling out to an external 100 line script”
- Aeolun 4y agoThere’s limits and degrees to anything. I guess I never get PR’s that are quite that boneheaded.
- interactivecode 4y ago100% agree, code review should be there to check if the code doesn’t contain any obvious security risks or mistakes. Designing features, architecture and learning should happen before someone even gets to the point of submitting a PR. Plus if it can be improved on in follow PRs then do that instead of blocking juniors with pedantics