3 ms·
I most recently worked on a 100% code-review team. Fabulous! In my personal experience, the hump from wide-eyed novice junior to productive contributing member
by rerdavies 4y ago
I most recently worked on a 100% code-review team. Fabulous!
In my personal experience, the hump from wide-eyed novice junior to productive contributing member really doesn't take that long when every line that everyone writes is code-reviewed. The first couple of code reviews might take longer than usual. But it definitely takes much less time than it used to take to bring a junior up to speed. No net productivity in the first year used to be a rule, when bringing juniors onboard in the dark ages of computing. With 100% code reviews, that process seems to take no more than a couple of months -- maybe even as little as one month. The difference is dramatic.
And it's a fabulous way to transmit not only good culture, but also love of our craft.
- mplanchard 4y agoWhat do you mean by 100% code review?
- bdangubic 4y agoEvery line of code must be code reviewed before it goes to stage/prod
- xxpor 4y ago… how else do people operate? Complete yolo?
- Aeolun 4y agoMaybe rubber stamp PR? We can say we review everything 100%, but practically this sometimes just means clicking the approve button.
- rerdavies 4y agolol. I've been doing this for a long time. It wasn't always done that way.
- ornornor 4y agoYou’d be surprised how many places operate that way. Or better, commit to master via the web ui because “it’s a quick small fix”