3 ms·
2/3 of these components are broken on iOS safari. I also see some questionable things happening in the hooks that might not make it past a review. It's a good
by AirMax98 4y ago
2/3 of these components are broken on iOS safari. I also see some questionable things happening in the hooks that might not make it past a review.
It's a good start, but definitely keep it up.
[1] — https://github.com/steven-tey/precedent/blob/main/lib/hooks/use-intersection-observer.ts#L38 https://github.com/steven-tey/precedent/blob/main/lib/hooks/... (you don't need the ref if you are ignoring exhaustive-deps, not sure why you stringify threshold)
[2] - https://github.com/steven-tey/precedent/blob/main/lib/hooks/use-local-storage.ts#L3 https://github.com/steven-tey/precedent/blob/main/lib/hooks/... (you maybe want to check if a key exists and warn before you set it)
[3] - https://github.com/steven-tey/precedent/blob/main/lib/hooks/use-scroll.ts#L3 https://github.com/steven-tey/precedent/blob/main/lib/hooks/... (you probably want debounce/throttle options here)
- taspeotis 4y agoThe front page is broken on Edge? https://i.imgur.com/kNOcEtB.gif https://i.imgur.com/kNOcEtB.gif
- steventey 4y agoThe z-index issues with the components have been fixed: https://github.com/steven-tey/precedent/issues/2#issuecomment-1382617245 https://github.com/steven-tey/precedent/issues/2#issuecommen... Appreciate the feedback about the functions – will get those fixed as well!