5 ms·
Giving a website access to star repos through the API for my convenience is not anything I should be banned over though.
by Aeolun 4y ago
Giving a website access to star repos through the API for my convenience is not anything I should be banned over though.
- yashap 4y agoThat I do agree with.
- gernb 4y agofrom github's pov you starred the repos. You signed up for a service the stars repos. it could have been starallthereposforme.com and you signing up a granting them permission to star repos is exactly what you wanted. So girhub is correctly assuming you wanted those repos starred. If you didn't want them starred you shouldn't have given the site permission to star
- tgsovlerkhgsel 4y agoGitHub should be able to tell that this was an abusive service doing it though. Legally they might be in the right, but punishing victims of social engineering further doesn't seem like a fair or smart business decision.
- olabyne 4y agoyep, it is easy for them to know if the star was the user itselft OR a third party app through the API...
- wikfwikf 4y agoBut an 'abusive service' might still involve misconduct by the user in question. Suppose there is a service which allows you to watch free porn videos as long as you hand over permissions to star a bunch of repos using your account. Clearly, the service is abusive and should be banned. But isn't it also quite fair for Github to penalize the users? They knew they were handing over something of value when they authorized the access. Either they chose to exchange their genuine 'Github clout' for something they wanted, or their accounts are spammy in the first place (for example, if they created an account solely to access that service).
- Aeolun 4y agoWhat you give the site access to is something like ‘Full-repository access’, the permissions aren’t granular enough to specify starring.
- bee_rider 4y agoIf you gave the owners of some website permission to star repos on your behalf, then you are trusting them; you are still the one responsible for your endorsements. Whether endorsing the wrong repo ought to ban worthy is definitely up for debate. But the question of whether you endorsed manually or delegated it seems unrelated.
- thriftwy 4y agoWhy have repo-starring API if you don't want users starring repos via API?
- bee_rider 4y agoYou will have to find someone who’s suggested that they don’t want users starting repos via API to ask them that. I’ve instead suggested that repos started via clicking and API should be treated the same way.
- encryptluks2 4y agoHow far does this extend though? Should people not be banned for granting access to any app, and doesn't the screen where you grant access present some kind of disclaimer or warning?
- rendall 4y ago> Giving a website access to star repos through the API for my convenience is not anything I should be banned over though. Sorry, hard disagree. You have responsibility, here. We all do. Be extremely wary of what privileges you are giving away, and do not hesitate to forgo sign-in when the privileges are unreasonable. Why would anyone click "yes" to a random site that wants control over their Github starring privileges without a clear explanation as to what they will be using it for? We can excuse the naïve, but this is a tech-related site. If you don't know, now you know.
- boarush 4y agoExactly. We keep asking that users must be asked for explicit permissions and granular scopes are for the good and then users themselves skip reading on these permission grants. Github has always (in my experience) been clear about what permissions are being granted to the site you're signing into, and if you don't agree, you can easily cancel the sign-on flow.
- execveat 4y agoIt's not clear at all. The scope UI says 'Repositories - Public repositories'. It does not sound dangerous and only reveals that the access is r/w (not r/o) after expanding the dropout. It does not mention stars at all. An example requesting the 'public_repo' scope (the client_id is a random one from the internet): https://github.com/login/oauth/authorize?client_id=33a703d019e0d23730ea&scope=public_repo https://github.com/login/oauth/authorize?client_id=33a703d01...
- 9wzYQbTYsAIc 4y agoSounds like the basis for an argument for refining the scopes such that it is abundantly clear which scopes write data and which ones do not. No one should be surprised that allowing an untrusted program to write files and permissions through an operating system could lead to a security exploit. Many would likely be cognizant of the risk of becoming a member of a botnet. Allowing untrusted programs to control your digital services is not fundamentally different, in my current perspective.
- contravariant 4y agoGetting your account hijacked and engaged in suspicious behaviour is cause for Github to suspend the account. You're not free from blame when you let your account be abused, at best you might be able to ask Github to help get control over your account back.
- anon84873628 4y agoExcept GitHub allowed the abusive service to integrate in the first place, and knows every request it created...