4 ms·
I've been using this for a few months and I love it. I will take this opportunity to gripe though and say that it doesn't handle DOM changes, e.g. if you're goi
by camgunz 4y ago
I've been using this for a few months and I love it. I will take this opportunity to gripe though and say that it doesn't handle DOM changes, e.g. if you're going through a form and you click an expander, the contents of that expander won't be translated if it was dynamically inserted into the DOM. This is more or less any AJAX request, or React/Vue component with its own data calls, etc. As a result, I often find myself falling back to Chrome if I need translations (recently moved abroad).
Also, it would be great if the models were cached. If I don't click "translate this tab automatically as I browse" I'll download the whole model on every page load. Not great if you're tethered to your phone :(
- jelmervdl 4y agoThat must be a bug. There is a lot of code in the extension specifically to make it track DOM changes and push translations for those as they happen. React pages are especially tricky to translate as the framework does not take kindly on external JavaScript swapping out text nodes. There’s code in the extension to work around that.
- andrenatalbr 4y agoDOM changes should be handled and it should be working still. Could you please file a bug https://github.com/mozilla/firefox-translations/issues https://github.com/mozilla/firefox-translations/issues with the proper steps to reproduce, please?
- camgunz 4y agoOh! They work now! Hell yeah nice :)
- andrenatalbr 4y agoI'm glad to hear.