3 ms·
It is possible I dont understand how GH works. I apologies if I was wrong. I was talking about (https://github.com/PolyMC/PolyMC/pull/1243 https://github.com/Po
by wisnoskij 4y ago
It is possible I dont understand how GH works. I apologies if I was wrong. I was talking about (https://github.com/PolyMC/PolyMC/pull/1243 https://github.com/PolyMC/PolyMC/pull/1243), which got 2 approvals. But it is possible I dont understand what approvals are, but to looks to me that people with authority on polymc to make changes approved of troll/destructive changes. But I am not an GH expert, maybe you dont need authority approve a PR that deleted the entire project and completly changes the readme?
- Macha 4y agoAnyone on GitHub can give a grey checkmark approval. It's basically just a thumbs up. The green checkmark approvals are the ones given by people who at time of approving had project approval permission and only these green checkmark approvals have any mechanical effect. Additionally, everyone who has ever contributed to the project gets a "Contributor" tag on their profile (current recognised contributors with permissions get a "Member" tag). You can see the trolling PR authors and approvers lack those. So no, the trolls, including those giving the grey checkmark approvals, are not the former maintainers.