30 ms·

I looked at a graph algorithm Bellman-Ford under C++ Why is Graph->edge a pointer not a std::vector Why does the Graph constructor not use member initializer

I looked at a graph algorithm Bellman-Ford under C++ Why is Graph->edge a pointer not a std::vector Why does the Graph constructor not use member initializer lists but assignemnt in the constructor body. So confidence in the quality of the code is not high. Then I see ``` this->edges = (Edge )malloc(E sizeof(Edge)); ``` This is not C++. Just stop reading it is not worth it. Find another source

xdavidliu 4y ago
yeah I agree. I think it's because they pretty much allow contributions of algorithms from various people and the code review standards are not super high. I recall at one point the BFS algorithm in Java actually used an ArrayList (roughly equivalent to std::vector) for the queue, which is silly because popping from the front is O(N), so I had to submit a fix for that: https://github.com/TheAlgorithms/Java/pull/3231 https://github.com/TheAlgorithms/Java/pull/3231 but I agree that basic low-hanging issues like this (and the exponential-time fibonacci that another commenter pointed out) really prevents me from taking this repo very seriously
pjmlp 4y ago
Unfortunately that is pretty much C++ as it still gets taught in many places.
- omegalulw 4y ago
  Not an excuse.
  - pjmlp 4y ago
    It isn't an excuse, rather a sad fact, and many people don't know any better. That is exactly why Val, Carbon and Cppfront aren't copy-paste compatible with C. Herb Sutter even mentions this at the end of his keynote.