3 ms·
> then a bit of mild criticism should probably be expected No they’ve every right to ignore your PRs for any reason or no reason at all. You aren’t paying them
by chrisseaton 4y ago
> then a bit of mild criticism should probably be expected
No they’ve every right to ignore your PRs for any reason or no reason at all. You aren’t paying them.
You can ask them to merge but you’ve got no basis to criticise them because they never promised you anything.
- chris_wot 4y agoIn that case, I guess forking the project to fix it whilst criticising them is disallowed?
- chrisseaton 4y agoCan I ask you to send me $100 and then criticise you when you don’t? Or is that an unreasonable criticism since why on earth should you send me any money?
- chris_wot 4y agoThat’s not unreasonable, if I used your work or wanted a change.
- chrisseaton 4y agoBut it's the other way around - why would you pay someone who was also using your work for free?
- chris_wot 4y agoWhat’s your point? If you have a popular project and you won’t accept a valid patch, a bit of polite criticism isn’t going to hurt you. Happened with the OpenOffice.org project. Caused the fork.
- imtringued 4y agoIt is the opposite, the submitter sends a patch aka $100 and then the maintainer rejects the money/patch.