3 ms·

Comments are arguably even more important than the code. This is a wonkass move.

by swayvil 4y ago

marcinzm 4y ago
If it's that important it should be a comment in the code rather than one randomly floating in GitHub.
- exhaze 4y ago
  There is “should” and then there’s what people actually do. Do you suggest that parent commenter should now go and change their policy on comments to solve this real immediate issue? If not that, do you have practical advice for parent? Parent commenter and several others said they found it very valuable. People seem to want this. Feels like enough of a reason to not remove it for all users with no heads up.
  - ryanbrunner 4y ago
    I don't think there's widespread usage of GitHub comments on commits as a code documentation method, since it would be almost entirely unusable (you wouldn't be able to see those comments unless you navigated to the specific commit on Github). The use case I do see sometimes is having a pull request made up of distinct commits which are each commented on, but that's already a bit of a poor UX in GitHub, easily worked around, and is pretty uncommon.
  - marcinzm 4y ago
    >Do you suggest that parent commenter should now go and change their policy on comments to solve this real immediate issue? I mean what is your suggestion to OP? Putting their head in the sand and acting like Github didn't remove a feature they in fact had removed? It's a very niche feature (so much so that more comments seem to misunderstand the feature than actually miss the feature) so the chance of Github not removing it is fairly low even if complaining causes them to delay it a bit.
shawabawa3 4y ago
This is a weird niche feature that I'm guessing 99% of GitHub users have never seen Certainly almost every comment on hacker news hasn't understood the change You can make comments directly on commit objects in GitHub, almost nobody ever does this. You used to see these comments appear PRs (but couldn't reply or resolve them) but now you don't. Nothing has changed with actual PR comments, or code comments, or anything that most people actually use
- WorldMaker 4y ago
  Also, it's a sort of "legacy" feature. Earlier versions of the PR UX made it tough to review commit at a time instead of just the Full PR Diff Firehose. (Now you can pull changes apart into commits or "updates" and several things between directly in the PR interface.) Commit comments and those automatically floating into relevant PRs was basically the old UX flow workaround to that. It was slightly less of a niche feature then. Now the PR UX supports those use cases more directly and there's much fewer reasons to use commit comments.

Comments are arguably even more important than the code. This is a wonkass move.

marcinzm 4y ago

If it's that important it should be a comment in the code rather than one randomly floating in GitHub.

exhaze 4y ago
There is “should” and then there’s what people actually do. Do you suggest that parent commenter should now go and change their policy on comments to solve this real immediate issue? If not that, do you have practical advice for parent? Parent commenter and several others said they found it very valuable. People seem to want this. Feels like enough of a reason to not remove it for all users with no heads up.
- ryanbrunner 4y ago
  I don't think there's widespread usage of GitHub comments on commits as a code documentation method, since it would be almost entirely unusable (you wouldn't be able to see those comments unless you navigated to the specific commit on Github). The use case I do see sometimes is having a pull request made up of distinct commits which are each commented on, but that's already a bit of a poor UX in GitHub, easily worked around, and is pretty uncommon.
- marcinzm 4y ago
  >Do you suggest that parent commenter should now go and change their policy on comments to solve this real immediate issue? I mean what is your suggestion to OP? Putting their head in the sand and acting like Github didn't remove a feature they in fact had removed? It's a very niche feature (so much so that more comments seem to misunderstand the feature than actually miss the feature) so the chance of Github not removing it is fairly low even if complaining causes them to delay it a bit.

shawabawa3 4y ago

This is a weird niche feature that I'm guessing 99% of GitHub users have never seen Certainly almost every comment on hacker news hasn't understood the change You can make comments directly on commit objects in GitHub, almost nobody ever does this. You used to see these comments appear PRs (but couldn't reply or resolve them) but now you don't. Nothing has changed with actual PR comments, or code comments, or anything that most people actually use

WorldMaker 4y ago
Also, it's a sort of "legacy" feature. Earlier versions of the PR UX made it tough to review commit at a time instead of just the Full PR Diff Firehose. (Now you can pull changes apart into commits or "updates" and several things between directly in the PR interface.) Commit comments and those automatically floating into relevant PRs was basically the old UX flow workaround to that. It was slightly less of a niche feature then. Now the PR UX supports those use cases more directly and there's much fewer reasons to use commit comments.