3 ms·
Isn't this exactly why you should use stacked PRs? That's what it looks like when I break a big piece of work into smaller pieces. What's the alternative anywa
by celtain 4y ago
Isn't this exactly why you should use stacked PRs? That's what it looks like when I break a big piece of work into smaller pieces.
What's the alternative anyway? If you don't want me writing 2500 lines of code in one area, would you rather I write 10 250 line PRs in 10 different parts of the codebase instead? Is that supposed to be easier to review?
Or is the rule just "don't write a lot of code in any short period of time"?
- morelisp 4y ago> don't write a lot of code in any short period of time Depending on the team this may be a completely reasonable policy.
- bpodgursky 4y ago(if you are on this team, run away as fast as you can)
- morelisp 4y agoNo, there’s no reason to run away from a team of overenthusiastic junior developers. Teach them instead and you’ll get a team of enthusiastic skilled developers, you just need to make sure they don’t make too much of a mess in the meantime.