5 ms·
I honestly hate that so much, it's a relief to read someone saying the same. I sort of almost made myself feel a bit better about it by thinking 'no, it's not
by OJFord 4y ago
I honestly hate that so much, it's a relief to read someone saying the same.
I sort of almost made myself feel a bit better about it by thinking 'no, it's not REST, we have reached the graphql server successfully and got a .. "successful" response from it, it's sort of a "Layer 8" on top of HTTP'. The problem is that none of the bloody tooling is 'Layer 8', so you end up in browser dev tools with all these 200 responses and no idea which ones are errorful. If any.
- Spivak 4y agoI actually think I agree with your former self, how do you tell the difference between a server and an application error? How do you tell the difference between "record not found" and "there is no GraphQL endpoint here at all"? Or "you are not allowed to access GraphQL" and "you are not allowed to access the server." Especially because error responses from your web server layer are usually really different than errors from your backends.
- remram 4y ago> How do you tell the difference between "record not found" and "there is no GraphQL endpoint here at all"? The standard 503 and 404 codes?
- Spivak 4y ago503 doesn’t map well to me meaning “you performed a successful GraphQL query but the result is that the thing you tried to query is missing.”
- remram 4y agoYes that would be 404. Similar to how there's no difference between "there's no /pets/" or "there is no /pet/15", they are both 404 for /pets/15 400 is also a good code for "your query doesn't make sense". Anything but 200 really.
- AdieuToLogic 4y agoWhile using HTTP status codes could work for GraphQL payloads which have only one operation in them, this approach would not work for those which have multiple[0]. 0 - http://spec.graphql.org/October2021/#sec-Executing-Requests http://spec.graphql.org/October2021/#sec-Executing-Requests
- remram 4y ago207 has been used for that for decades. GraphQL looks like it's been implemented by someone who thought 200 and 404 were the only possible codes.
- AdieuToLogic 4y ago> 207 has been used for that for decades. That's a WebDAV status code. > GraphQL looks like it's been implemented by someone who thought 200 and 404 were the only possible codes. Maybe. Or maybe they decided that a 2xx status would be interpreted as "success" by a non-trivial set of libraries and/or systems. Either way, take it up with the standards committee :-).
- Aeolun 4y agoI mean, I agree. Given the nature of the protocol, it makes sense that a half-successful response of independent queries would still return a 200 on the network protocol. That doesn’t mean it’s not bloody annoying.