2 ms·
Yeah I agree w/ you. I think there are three major problems w/ code review: - reviewer ego - author ego - reviewer ambiguity "Solving" ego is involved, but
by camgunz 4y ago
Yeah I agree w/ you. I think there are three major problems w/ code review:
- reviewer ego
- author ego
- reviewer ambiguity
"Solving" ego is involved, but easy: you have to encourage trust amongst your team, and that can't happen in code review--it's too late.
Reviewer ambiguity (being non-confrontational and wishy-washy when you really mean "this is an XSS vuln, you gotta change it") is an attempt to solve ego, but always fails.
I'm not saying be a jerk, you have to act with compassion and empathy always, which is a marathon and not a sprint. But you're not gonna fix ego/trust/respect issues at code review time, no matter how deferential you are.