4 ms·
I’m not sure what you mean by this example. From what I see, somebody submitted a bug fix that hadn’t been approved/merged by you for 6 months. Then some quite
by allarm 4y ago
I’m not sure what you mean by this example. From what I see, somebody submitted a bug fix that hadn’t been approved/merged by you for 6 months. Then some quite rude conversation happened “Don’t act as my free time is owned by you”. I mean both sides look quite ugly in this particular case to be honest.
- dom96 4y ago> From what I see, somebody submitted a bug fix that hadn’t been approved/merged by you for 6 months. From my perspective the PR was reviewed and was stuck on a test case being created. The author of the PR even stated "I'll try to make a simple test case." so as far as I'm concerned the ball was in their court. But you know, reviewing PRs takes time too. Acting entitled about a review taking a long time shouldn't be done either.
- allarm 4y ago> But you know, reviewing PRs takes time too. I agree. I’m just saying you were rude too.
- abnry 4y agoHe was rude, but he didn't initiate it. Frankly, he openly communicated his priorities (other things are on the list) and then got snark. So he responded in kind. Very little to blame the maintainer here.