2 ms·
I would never use something like this. Seems to me that it's just a heuristic based on the char diff count. I made a simple repo that has a shell script that do
by donkarma 4y ago
I would never use something like this. Seems to me that it's just a heuristic based on the char diff count. I made a simple repo that has a shell script that does rm -rf /usr/old_files_and_stuff, added a space next to the first slash and it was approved, which is dangerous. If I need to manually verify it anyways for stuff like this, why would I use it?
- iamnafets 4y agoI generally feel the same way, but just to steel man the argument: would your manual code review process have caught this issue? Sometimes we compare new things against their hypothetical ideal rather than the status quo. The latter is significantly more tractable.
- Aeolun 4y ago> would your manual code review process have caught this issue? On a one character code change? I’m inclined to think so.