4 ms·
In order to get around some of the issues here we try to have lots of micro-PRs rather than large ones. Often this means doing small refactors in their own PRs,
by gtf21 5y ago
In order to get around some of the issues here we try to have lots of micro-PRs rather than large ones. Often this means doing small refactors in their own PRs, letting them be reviewed separately, and using them as the basis for the actual change (which will, again, sit in its own PR).
- Supermancho 5y agoMy favorite is the recursive PR. Big PR gets split into 10 small parts. PR X, someone notices that they should all have some change, because of some eventuality or commonality that is obvious in part X. PR is now in 10 small parts again. Repeat.
- epage 5y agoThere is a tension between digestable changes and context to understand why a change exists. I wish review tools handled multi-commit and stacked PRs better (Phab has its share of problems).