4 ms·

I'm annoyed ktrace wasn't revisited. If the integer was getting truncated, why did ktrace print that the request was still VIDIOC_S_FMT? Shouldn't it have print

I'm annoyed ktrace wasn't revisited. If the integer was getting truncated, why did ktrace print that the request was still VIDIOC_S_FMT? Shouldn't it have printed some goofy number that didn't match?

tedunangst 5y ago
That is weird. I don't see an easy explanation. kdump uses unsigned long.
- deleted 5y ago
  [deleted]
loeg 5y ago
Kdump truncates to a 32-bit value: https://github.com/openbsd/src/blob/master/usr.bin/kdump/kdump.c#L1464 https://github.com/openbsd/src/blob/master/usr.bin/kdump/kdu...
- tedunangst 5y ago
  Oh! That's dumb. The printer correctly uses unsigned long. https://github.com/openbsd/src/blob/master/usr.bin/kdump/mkioctls#L96 https://github.com/openbsd/src/blob/master/usr.bin/kdump/mki...