3 ms·

Is it just me, or does this not even install correctly with pip install .?

• lopatin 5y ago
  One does not simply pip install Communist Revolution. There are much more steps. Do you even have a manifesto?
  • julius_deane 5y ago
    Obviously an overlook mistake from our comrade jokteur. https://packaging.python.org/en/latest/guides/using-manifest-in/ https://packaging.python.org/en/latest/guides/using-manifest...
    • pdonis 5y ago
      He wouldn't need to use MANIFEST.in, just fixing setup.cfg would be enough. The simplest fix would be to set py_modules = communism and remove packages from setup.cfg altogether (and then the __init__.py file in src/ could be deleted since src/ is not a package).
      • jokteur 5y ago
        Author of the project here. I took very little time to write this joke, this obviously an oversight from me. I was working on my conda installation, so I didn't look further. It is fixed now, it should be working.
        • pdonis 5y ago
          Yes, it works now. Note that since you have no packages, you can omit include_package_data = True from setup.cfg, and since you no longer have the src/ directory, you can omit the options.packages.find section from setup.cfg.
  • erwincoumans 5y ago
    pipestroika!
• bmitc 5y ago
  > not even install correctly with pip install Big surprise. :p
• tjpnz 5y ago
  Consult your little red book. It explains the situation very clearly.
• jokteur 5y ago
  Author of the project here. I fixed the issue. But I think it unintentionally not working first time is speaking for itself.
  • pdonis 5y ago
    Saw the fix, thanks! Was it also unintentional that instances of classes, after they have been converted to communism, compare equal with anything whatever, and hash equal to the integer 1 and the boolean True? >>> import communism >>> class MyClass1: ... pass ... >>> class MyClass2: ... pass ... >>> communism.revolution(globals()) >>> MyClass1() == None True >>> set((MyClass1(), MyClass2(), 1, True)) {<__main__.MyClass1 object at 0x7f8f3532a820>} >>>
• anm89 5y ago
  [flagged]