3 ms·
Don't do this. It's not a demand list, it's a comparison to a competing product. Do you want a PR that's just s/.*/docs.google.com/? That's what you're passi
by Dylan16807 5y ago
Don't do this. It's not a demand list, it's a comparison to a competing product. Do you want a PR that's just s/.*/docs.google.com/? That's what you're passive-aggressively asking for.
- JulianMorrison 5y agoIt's a wish list, but it's full of things I know are hard. Or at least things where the difference between doing them kinda poorly, and doing them with style, is a few billion dollars worth of established natural language processing infrastructure. Google genuinely understands the sentence you're trying to type - for some AI value of "understands". Therefore its suggestions are succinct and sensible.
- ivanche 5y agoDon't do this. Get serious man, you know what is a PR and what is a demand for a free work. That's what you're passive-aggressively asking for.
- Dylan16807 5y ago> That's what you're passive-aggressively asking for. I don't know if you're wording it way because you're doing a bit or you didn't look at my username? > you know what is a PR This part doesn't make sense to me. > and what is a demand for a free work And this is not a demand for free work. If I comment on a project that I'm going to keep using an existing product because it has this big entrenched feature base, that's the exact opposite of being demanding and binding myself to a project. It's an acceptance of the status quo. It gives some feedback as to what people find important, but it's not a request to implement half of google docs, and it doesn't make sense to try to invert it into an invitation to submit a PR that implements half of google docs.
- ivanche 5y ago> > you know what is a PR > This part doesn't make sense to me. A proper PR (pull request on GitHub, not public relations, just to be clear) contains a working implementation of some feature or a bugfix. Ideally it also follows the style of the said project, is well tested etc. If somebody opens a "PR" with no source code and the whole body of PR is, for example, "Replace your project with google docs" or even "s/.*/docs.google.com/", that's not a PR, that's wasting project maintainer's time. If somebody opens a PR that says "Hey could you add feature X?" that's also not a PR. At best that's a feature request.