11 ms·
Rust maintainer perfectionism, or, the tragedy of Alacritty (2020)
- akagusu 5y agoAnd the honeymoon is over.
- faraaz98 5y agoYeah theres so many issues popping out of the rust community and projects I didn't think that would happen. Guess I have a lot to learn
- speed_spread 5y agoThis isn't specific to Rust. PRs are hard, people want different things, nothing is free, etc.
- setpatchaddress 5y agoThis, so much. I maintain corporate, closed-source components which are central to my org’s mission and have to request radical changes on PRs submitted by other teams on a frequent basis. It’s really not “perfectionism” to avoid introducing serious maintenance issues and bugs long-term. This is like jwz’s interaction with the emacs team decades ago — the story was that the emacs team was being unreasonable about merging some changes jwz/Lucid wanted. If you actually read the correspondence, turns out jwz wasn’t listening to review feedback. The feedback was completely technically reasonable from a maintainer’s perspective and jwz/Lucid just wanted the code merged without consideration for the emacs team’s future plans.
- akagusu 5y agoIt is not specific to Rust of course, and it happens all time with open or closed source software, but it get interesting when people start to rant in public. It is like marriage. Everything is fine in the honeymoon, even when it is not, but after that, things start to get a little messy.
- maxekman 5y agoAh! The “classic” ligature issue. Have been following that for a while. Kind of given up hope that there will ever be any support for it. Edit: punctuation
- Grumbledour 5y agoIndeed. I also switched to Kitty a long time ago. While I personally would like a tty with less features overall, this one was absolutely a deal breaker for me.
- erk__ 5y agoThere is also Wezterm which does have support for ligatures https://github.com/wez/wezterm https://github.com/wez/wezterm
- rbanffy 5y ago> The “classic” ligature issue. We try to make our terminals do things no terminal (remember those boxes with a CRT that used to be in a room, then became ubiquitous enough to end up on our desks) ever did, or considered doing. Do I enjoy being able to partition a window without needing tmux? Yes. Do I like text reflowing when I resize the window? Sure. Do I find Tektronix mode useful? No. Do I find it fun? Of course! We all are passionate about some thing or another (I, for instance, maintain an IBM 3278-2-like terminal font), but I have to agree that, when someone says my suggestion for adding smooth scrolling or double width/height attributes to VTE (I promised to add Tek support to it, but, like so many other side projects, I didn't have the time to start it) is niche or, worse, a Terrible Idea, they are not doing that out of cruelty, but from a position of "I'll have to maintain this idea only you like forever", and, in their place, I'd probably do the same (as I have in the past with `pip-chill` (another thing I maintain), when I think an idea is not great). OTOH, from the other side, I'd love to see https://github.com/urwid/urwid/pull/434 https://github.com/urwid/urwid/pull/434 merged :-( And, of course, having https://github.com/htop-dev/htop/pull/736 https://github.com/htop-dev/htop/pull/736 shot down was disappointing, but understandable.
- 5y ago
- brabel 5y agoI wrote a blog post showing how Rust performance can be pretty terrible when you write code like you would in other languages (something people recommend to beginners to avoid having to deal with advanced concepts in Rust)... big mistake: I am pretty sure several dozen "Rustaceans" felt the need to write to me explaining how terrible my code was, how it could be much faster if I just did x and y (which were true, but beyond the point I was trying to make), how I didn't know even basic CompSci (well, I do, I managed to get a degree and work in this field for nearly two decades, but I disgress)... it was a pretty harsh experience, and I am now much more conservative with talking about my Rust code publicly as a result!
- alpaca128 5y agoIt's a double-edged sword. Rust gives all the tools to make really performant software and tries to keep inefficient operations visible. But in many situations doing it the "proper" way requires a deep understanding of the type system and a lot of experience so you can tell the compiler what you're trying to do. Most things just aren't performance critical enough to warrant a day of experimentation, and many features don't really need generics and all the syntax overhead that comes with them. When you combine that with perfectionists it can probably get annoying. It's sad this is common enough to drive people away, because I think Rust is a great language and using it "well enough" is the first step to learning how to do it better. Imho it's not realistic to expect everyone to really understand all aspects of traits, lifetimes etc. because those can get really tricky really quick and not every behaviour of the compiler is consistent in those areas.
- rob74 5y agoI don't have any first-hand experience with this topic, but it seems reasonable that Rust has a special attraction for perfectionists. So many features to play with to get the most efficient, memory-safe etc. code...
- cryptoboy2283 5y agoCould you share the link to your blog post?
- c7DJTLrn 5y agoI think many developers treat PRs as an opportunity to gatekeep. I'm not a very politically correct or emotional person but I think gatekeeping/nitpicking is extremely demotivating and it should be avoided wherever possible. When I review PRs, I'm looking at the big picture. I'm looking to see if it introduces security issues or diverges from standard practice. I don't care if there's a slightly better way which reduces the number of branches - if I see it as worth changing I'll do it myself after the merge. I'm not looking for all the reasons why it can't be merged, I'm looking for the minimum changes needed to make it comply with the codebase's existing standards. This post also highlights one of the reasons I fell out of love with Rust. There's too many ways to do things.
- mgaunard 5y agoThe whole point of PRs is to gatekeep. They are there to enforce that the change is consistent with the owner's standards.
- AlexanderDhoore 5y agoWhat about adding it to the PR yourself? Why should it be the same person creating/fixing the PR?
- c7DJTLrn 5y agoI'm assuming you mean't "why shouldn't". Because a lot of critique in programming is a matter of personal opinion and I see it as impolite to block somebody else's hard work because it doesn't look the way the reviewer wants. Of course, it's a different matter if the code is insecure or something but I really don't care about the extremely fine implementation details.
- brabel 5y ago> if I see it as worth changing I'll do it myself after the merge. 100% agree! Someone unfamiliar with the code base takes the time to make a change that improves something, for free and without asking for anything in return... I always try to take it as it is, only asking for changes that are really necessary to avoid bugs or serious problems, then I normally go and do a post-merge cleanup to try to keep things organized in the way I want (which is hard for outsiders to do themselves). > There's too many ways to do things. Exactly! That's why Rust PR reviews are always dangerously close to descending into nit-pick shit shows - there's ALWAYS a 0.1% nicer way to write something, you can always change it to make it 2% more efficient, or to avoid allocating as much memory, or avoid using explicit lifetimes, or avoid dynamic dispatch.... the list goes on.
- roperzh 5y agoI understand the point of view of the author, but at the same time I appreciate how simple and not bloated Alacritty is, there is great software out there but terribly bloated with features that become useful only in edge cases.
- GekkePrutser 5y agoA lot of their comments seem justified though and it looks like you were learning a lot from it as you mentioned it was your first rust merge. Also a lot of the delay was because you didn't have time to work on it as you mentioned in 2019 :) I'm not a developer but I read through the thread to see what it's about. But I think most comments were constructive criticism or just non blocking suggestions even. Though code quality seems to be a higher goal than in most projects I know, that's kinda admirable too. I can imagine your side too though, it's frustrating to be working on something and not seeing it go forward.
- japanuspus 5y agoTotally agree: the issues raised are not just cosmetic -- several of them address fundamental thread safety issues that appear to be lost on the author.
- EugeneOZ 5y agoIt's the author of 8chan, so libel is not surprising here.
- wchar_t 5y agoBennan has since repudiated 8chan and has fought for it to be taken offline. Let's not judge him too harshly.
- EugeneOZ 5y agoNo, he didn't fight for it. He sold that site - that’s all. When he had the power to stop GamerGate imageboards - he didn't. When he could remove boards with CP - he didn't. What I wrote is far from “judging him too harshly” :) He only apologized for not removing the shooter's manifests. He didn't apologize for GamerGate, CP, racism, neo-nazism, and other terrible things. His words about the 8chan shutdown - “I was not even that upset about that” [1]. You can’t call it “fighting”. [1] https://jacobinmag.com/2021/04/fredrick-brennan-8chan-internet-4chan-qanon https://jacobinmag.com/2021/04/fredrick-brennan-8chan-intern...
- davidhyde 5y agoI have also experienced this frustration and it has turned me away from projects before. There is always some reason to block a PR. However, I found that creating my own open source projects helped me sympathise with maintainers of popular projects. I think of it this way: Say you work at a company and there is a lot of work to do. The bar can be low for accepting PRs because it is assumed that the author will stick around to fix any issues they caused and you have to deliver so in it goes. However, a maintainer of an OS project first of all probably does not have the same problem you are trying to solve AND they may not trust that you will stick around to fix any problems your code may cause in the future. On the other hand they want you to contribute because this makes the project more popular and there is a chance that you will become a maintainer yourself. It's a balancing act. This is why it is important for a channel of communication to be opened between all those interested in the project (a chat group) to grow rapport.
- masklinn 5y ago> The bar can be low for accepting PRs because it is assumed that the author will stick around to fix any issues they caused and you have to deliver so in it goes. On the other hand it can be high because you’ll be the one on call when it blows up in production, or having to scramble with an emergency security fix.
- buro9 5y agoA PR is a gift and a burden. A gift of someone else's effort to contribute and push something forward. A burden because once received, future maintainance of the gift is really on the one who received the gift. It may as well be the gift of a kitten... you now have to look after the kitten for the next 12-15 years. Is it socialised? House-trained? How much effort does this take when there are also gifts of other animals stacked up behind this one? I don't think it's constructive to paint the approver as gatekeeping, or perfectionist. What does that achieve? Surely it's better to meet halfway on the gift exchange, thank you for the PR but it does need to be house-trained and socialised, etc.
- gojomo 5y ago"Open source: the gift that keeps on taking." (Earliest use I can find here – https://twitter.com/devbisme/status/1017520086096207874 https://twitter.com/devbisme/status/1017520086096207874 – but perhaps goes back much further.)
- deleted 5y ago[deleted]
- deleted 5y ago[deleted]
- PragmaticPulp 5y agoThe problem is when contributors view their contributions as a gift rather than a starting point for collaboration. Rejecting a gift is quite a rude gesture. Rejection a PR contribution until it receives further iteration after some thoughtful feedback is anything but a rude gesture. I think this mindset that open source maintainers are obligated to accept PRs as gifts is the source of much of this frustration. The PR should be a starting point for further discussion, iteration, and collaboration, not a one-way gift that places a burden on the maintainer to satisfy the wants of the contributor.
- hiyer 5y agoI used to use kitty, but its CPU usage was on the higher side on my laptop. I tried alacritty but the lack of tabs (after using kitty for a long time) was a deal-breaker. I'm currently using Wezterm[1], another rust-based terminal, which has tabs. It's worked great for me so far. 1. https://github.com/wez/wezterm https://github.com/wez/wezterm
- roperzh 5y agoby reading through the issues in Alacritty you realize that it's optimized for a very specific set of use cases, for example if you're using a tiling window manager you don't miss tabs at all (in fact they are an annoyance)
- konart 5y agoOr tmux.
- antihero 5y agoDo you need tabs still if you use tmux by default?
- hiyer 5y agoNo. I used to use tmux extensively when I was doing a lot of remote shell work, but I don't do that any more. For local work I'd still use tmux if there was no other option, but kitty spoiled me :-).
- SloopJon 5y agoMy favorite way to use tmux or et is with tabs in iTerm2.
- lopuhin 5y agoI prefer a tab for each machine, including local, and then each tab has a tmux or ssh + tmux.
- franee 5y agoJust moved to kitty from iterm2 a few weeks ago. Started with alacritty, but without tab support, was a deal-breaker for me. I use tabs in kitty with tmux on each tab. Each tab is a context in my environment (dev/services/ansible/terraform/etc).
- EugeneOZ 5y ago“They don't want to merge my code with unsafe and I can’t prove it's actually safe”. 2 examples extrapolated to the whole community and language. Is there any particular reason to resurrect it from 2020?
- brabel 5y agoIt's only two examples given in this post, but I think it's just reasonable to assume there are many more examples the author could give otherwise I doubt they would take the time to write about it... also, if you've been trying to participate in open source Rust projects, you know it's not just these two projects.
- EugeneOZ 5y agoJust open the link to PR - the author is arguing that unsafe code should be merged but doesn't mention it in his rant. Skepticism about unsafe code is not perfectionism.
- an_ko 5y agoAs a free software maintainer, I have high standards for quality because (a) I like it that way, and liking it is why I do it for free, and (b) if your PR sucks, chances are I'm the one who has to write the docs, fix the bugs, and deal with the design consequences forever. If you disagree with maintainer priorities, just fork it! Merge whatever you want, advertise your fork in the unmerged PRs' comments, see what happens. Nobody will be offended; the license specifically encourages this. Maybe you'll find you're just better at this maintainer thing and the world now contains better software, or maybe after a few years you'll find that you understand their perspective.
- draw_down 5y agoThat is a shame, but it seems like the system worked here? Kitty is better (so the author says), presumably at least in part due to being less conservative.
- ljm 5y agoWhile it can be frustrating I think it's fair to say that it's up to maintainers or project owners to decide what fits into the vision of their project, and therefore contributing a change (particularly a feature addition and not a bug fix) does come with the sizeable risk that it's not actually what the maintainers want and will therefore be rejected. Of course, if it's too strict then people will stop contributing entirely. But if it isn't stright enough then the project can suffer from bloat and a lack of a unifying vision. This becomes less of an issue if there's some level of expectation management involved. e.g. here is what we would like contributions for, here are things that we won't, and if you're unsure about any of it, open an issue about it before investing all your time and effort.
- gojomo 5y agoNo opinions from me on Rust pacing/contribution standards in general, or `alacritty` specifically. But from sidelines, I find it ironic that a project whose name is a play on the word 'alacrity', meaning "cheerful readiness, promptness, or willingness", is earning criticism for its plodding perfectionism & willingness to say 'no'. (Maybe users/contributors are subconsciously applying a higher standard via the connotations of its name?)
- rtfeldman 5y agoPosts like this are major contributors to maintainer burnout. Whatever value they have as a signal boost is a rounding error compared to the harm they cause to individuals as well as to the culture as a whole. Please don't ever post things like this. If you're this frustrated that the people who make free things for you aren't donating their time to you in the way you'd prefer, grab a drink with a friend and vent to them in private instead.
- brabel 5y agoAs I maintainter myself, I completely disagree. It's a fair complaint that everyone contributing to open source will eventually suffer from. > Please don't ever post things like this. What the hell, is this against any HN policy? Or you think no one should post their point of view here if it's against yours? EDIT: I think it's important to note that burnout is a result of you having an issue within yourself (at least in the context of voluntary projects), it's not something others do to you... you can choose to ignore all pull requests, for example, or say in your README that you won't accept any (I've done that myself to projects I wanted to keep in a certain "permanent" state for reasons). If you choose to engage in discussions, that's your call.
- atoav 5y ago> I think it's important to note that burnout is a result of you having an issue within yourself I think this is an oversimplification. You can be perfectly happy with yourself, but if your environment creates a neverending treadmill of situations that drains your soul, you will get burnout if you cannot find any mechanism to cope with it, to avoid it or to deal with it. And in open source we are each others environment. If you have 100 well researched issues written in a friendly tone you will certainly feel a different motivation to tackle that backlog than if it are 100 toxic spitting well-researched issues. The same goes for how we talk about each other in public. If you think a PR should have been merged, just talk to the maintainers in a non-public setting (Chat or whatever) and explain why you want it merged, what you would be willing to do for it and how they could see this happen. If they still don't like to do it, just fork it and do it yourself.
- globular-toast 5y agoI do think the pendulum has swung a little too far towards perfectionism now. I notice it with static typing in languages too. Some of the discussions about what the "correct" way to encode the problem into the type system are leaning towards insane. Yes, we like software for its own sake and it has the potential to be beautiful, but at the end of the day it is supposed to be there to get things done. It's lovely when you find a design that both meets its specification fully and is completely elegant. But focussing on one thing at the expense of the other isn't going to solve any real problems. An extreme position is rarely a good thing.
- muxator 5y agoI'm perfectly ok with a maintainer reserving to himself the right to modify or even force-push a PR. If feature-wise the PR has value, but there are other requirements that have to be meet in order for it to be mergeable, I see no problem in the maintainer making his hands dirty. This contributor's work is recognized, and the maintainer can keep growing the project the way he wants. Not every occasional contributor will become a project member, so it makes no sense to impose too much burden on him. Maybe he only wants an interesting feature added. Some of them will eventually become interested in becoming regular contributors, and that is even better, but every one should be left freedom of choice. In my experience as Etherpad maintainer (1.6.5 through 1.8.4) this approach worked very well. For example https://github.com/ether/etherpad-lite/issues/3540 https://github.com/ether/etherpad-lite/issues/3540 (and the related PR https://github.com/ether/etherpad-lite/pull/3559 https://github.com/ether/etherpad-lite/pull/3559) where deep changes that went very smooth, not only code wise, but above all wrt the relation with the contributor, who was smart and collaborative.
- 1_player 5y agoThe issue with many open-source projects is that most maintainers are of the philosophy of "let's ship it, we can improve it later" for their own code, while they expect incoming PRs to be perfect, to handle all corner cases, past and future, or else they'll be stuck in limbo, unanswered or picked apart over months, one line at a time, until they ask for a perfect implementation which requires 10x the time investment. All for fixing a bug that might affect people. I admit I personally have never participated much in open-source development because, even as an experienced software engineer; I've never had many good experiences with merging code into public repositories, unless it's a very small project, where contributions are very welcome, because the level of perfectionism maintainers require from first time contributors kills any enthusiasm one might have even in the smallest of changes.
- a_rustacean 5y agoIt's easier to understand the future consequences and limitations of code you wrote yourself. The main challenge in open-source is communication.
- hprotagonist 5y agofwiw i think the last time i rebuilt alacritty was a year ago or more, and i can’t say i’ve felt the burning desire for new features or anything…
- frazar0 5y agoThe author raises an interesting argument, but I don't see how the "maintainer perfectionism" issue is specific to Rust in particular. Indeed, the two examples they mention are both related to Rust somehow, but is it enough to generalize to the whole Rust ecosystem?
- xyzzy_plugh 5y ago> So, here we are in 2020, and nix#864 remains unmerged. Fred, you say, you overreact. I read the entire PR. I _want_ to agree with the author, but I didn't find this reasonable. The feedback, for the most part, was not about being perfectionism. Not remotely. It's about being correct. This is not unique to Rust, which as a language spends a lot of time being correct in a few dimensions, but pretty traditional. You can't just call library functions from a multi-threaded context without understanding if they're thread safe or not, if they're reentrant, without using appropriate buffers or handling errno correctly. Well, you can, of course. But then you have bugs, and crashes, and race conditions. I don't mean to come off harsh but this is pretty bog standard stuff. Maybe the author is new to all of this, maybe not, but complaining about perfectionism when the issues being raised are almost entirely real actual issues really rubs me the wrong way. Take a look on LKML, or Git's mailing list, or on any serious project from the last 20 years. The barrier to entry isn't mailing lists, or Torvalds, or perfectionism or gatekeeping. The fact is that most programmers do not have the patience, skill or experience to write half-decent code that isn't bug-ridden garbage. I don't think any project maintainer ever wants to accept contributions that make their life harder.
- klelatti 5y ago> The fact is that most programmers do not have the patience, skill or experience to write half-decent code that isn't bug-ridden garbage. Whether or not you are right on this issue is this really the way to generalise about current / potential contributors? Why would anyone even attempt to contribute if their efforts are likely to be dismissed in this way? Edit: I’m making no point about quality or otherwise of contributions or whether maintainers should accept them. Just that phrases like ‘bug ridden garbage’ don’t suggest a welcoming atmosphere.
- iamthepieman 5y ago"Why would anyone even attempt to contribute if their efforts are likely to be dismissed in this way?" Because if they pass the bar knowing what it is then they also know that they're part of the club of developers who have the "patience, skill or experience to write half-decent code that isn't bug-ridden garbage."
- solmag 5y agoThe Rust library ecosystem is small but they tend to be high quality IME; this is a drawback of it I suppose.
- mgaunard 5y agoA project owner has the final say into what goes into his project. Don't like it? Just make your own project. Why is the Rust community so full of entitled drama queens?
- epolanski 5y agoIt's not just the Rust community, it feels like the entire OSS community cannot grasp that you can at any point fork and have your own version. That's the biggest freedom we're given, expecting that any of our ideas or features should make it into a main release is both delusional and arrogant. On a more general note, I believe more and more software should be modular and allow for extensibility. GNU and the FSF are good examples of writing very complex but composable software.
- pella 5y agoThe "Art of Rejecting pull requests" is hard. read more: "Polite Technology This is a book about the social interactions and situations that are the underpinnings of the open source world. It's about how humans collaboratively create software." https://polite.technology/preview https://polite.technology/preview
- antihero 5y agoHa, trying to get Alacritty to have a native-feel icon for macOS which had basically zero drawbacks and most other applications do was met with a straight up NOPE. Not up for debate, people supplied the assets and I even made a PR, nope, closed. Even though it was in a directory full of platform specific stuff (Alacritty.app resources), it was decided that it couldn't differ from the other icons, so Alacritty has to stick out like a sore thumb on the dock unless you manually patch it each time.
- neilalexander 5y agoThis is frustrating because it is a change that has no other impact aside from making your users happier. The justification for not merging that is nonsense.
- purple_turtle 5y agoIt increases complexity of future maintenance, no change is costless.
- eminence32 5y agoYou don't have to agree with the justification, but calling it "nonsense" seems a bit unfair. The github threads are a bit long and with several different points made, but my reading of the bottom line is: "this is not the official icon, it should not be in tree"
- chrismorgan 5y ago[Edit: I wrote some stuff earlier based on other PRs that were done even worse, before I found #3926, so I’ve deleted that other stuff as unlikely to be what’s referred to.] I’m guessing this is about https://github.com/alacritty/alacritty/issues/3926 https://github.com/alacritty/alacritty/issues/3926. I can well understand this being knocked back; as a non-user of macOS I would knock it back too. The main proposed option is frankly a fairly poor reimplementation of the logo and loses too much of the character of the original logo. A more conservative adjustment might stand a better chance. (chrisduerr also quibbles over the idea of maintaining different icon graphics for different platforms, but I suspect this may be more a further complaint about something that he’s otherwise already not happy with: that if the proposed icon was actually true to the Alacritty logo he wouldn’t object so much, though it’s still not an entirely unreasonable complaint—Apple are probably going to change their style in another year or two anyway.) Admittedly the current icon isn’t great, because it’s taking the full width available to it, where native square icons look to go for 10% border on each side. I imagine you might have much more success just fixing the icon’s scaling (e.g. down to 90%—because it’s not square, 80% would probably be too far). You could also try adjusting the aspect ratio just a bit, slightly squarer, but leaving everything else the same—that’d be about as conservative as you could get while still varying it for macOS. That’d make it a fair test of the idea whether chrisduerr is actively against having different source icons for different platforms.
- the__alchemist 5y agoI've noticed the same. For example, for Rust embedded Hardware Abstraction Libraries, I had to abandon the existing ones and start a new one: The existing ones were missing features, had bugs etc. I initially attempted to fix them with PRs, but couldn't get anything merged due to complaints such as those in the article! It's as if the maintainers would rather have a sparse debate over the course of months trying to get things perfect than fix the problem or add the feature. If you don't like the code style of the PR, just do the fix yourself. It would be a lot easier than arguing! It was easier to start fresh than get PRs merged. This happened even for clean kill bug fixes. For my own projects, my bar for merging is "Does this improve the project". If there's a code style issue I don't like, I'll merge, then make the change myself after. If it's an idea I don't like, or determine is out of scope, I'll state clearly that I have no intent to merge it. Sometimes these are an issue of available maintainer time. Eg, the maintainer may be busy, and doesn't want to dedicate time to a project. So, you end up in code-style debates, where response take weeks etc. It's mismatched expectations between maintainers and users. Or if the maintainer doesn't have time to test or evaluate a change in all cases, a conservative call is to not take the risk of unforseen consequences. Overall: I also agree with the points others here make about the owner-maintenance burden of PRs, no obligation to merge code you don't agree with, validity of safety concerns etc. It means you need to treat these on a case-by-case basis. In the case I outlined above, it would have been preferable not to fragment the embedded Rust OSS community by introducing a fresh HAL, but I had to to meet project requirements.
- mjw1007 5y agoA suggestion for anyone using gist.github.com for messages like this: please put the date of writing prominently near the top, as the platform won't do it for you in the way something designed for blogging would.
- echlipse 5y agoMy first commit to a fairly big opensource project is still not merged. The project is very beginner friendly but the project maintainers wanted my commit in a certain way as per their standards. It was not even the actual code but the commenting and variable names that needed to be changed. I had to re-review it many times before it was ready for merge. It took almost 2 to 3 months with some long time gap before I made perfect submission. In this process it seemed crazy to me why anyone will be looking through all this code made by a beginner with so many mistakes and patiently guiding them through it for free of cost. It made me appreciate their work more. Even though it isn’t merged yet I still got to learn a lot in this process. Btw the PR didn’t get merged yet because we need to fetch data using an api of another source which is poorly documented.
- the_mitsuhiko 5y agoI very much appreciate that Rust crates aim a little bit higher. I think it’s a different story for apps where shortcuts are a good idea.
- DoubleFree 5y agoThis reminds me of a blog post from Aleksey Kladov: https://matklad.github.io/2021/01/03/two-kinds-of-code-review.html https://matklad.github.io/2021/01/03/two-kinds-of-code-revie... They state that reviews are not only meant to ensure good code, but also good coders. That means mentoring, but also merging the code if it's not perfect. Then, afterwards, when touching the affected part of the code again, cc the original author in a fixup PR. I have first-hand experience with this way of reviewing and I really like it.
- nixpulvis 5y agoWhy not simply have the discussion in the review itself? Must we merge everything, just so people feel empowered? It's chaos to have to constantly revert and/or refactor everything. People should be empowered not by the merge, but by the progress. They key, from what I've seen, is to facilitate useful conversation. Keep comments relevant and people will learn. Avoid politicking, while still providing evidence for your case. Typically, show your own work. The best review points clearly towards a better result. Finally, acknowledge your own limitations as a reviewer. We're all human, to pretend otherwise does yourself and others a massive disservice. (But what do I know. I've been out of the game for a while now.)
- bluesnowmonkey 5y ago> Must we merge everything, just so people feel empowered? Sort of, yes. People develop confidence and expertise from repeated success at accomplishing things. Success creates confidence creates more success. You have to give people room to get that flywheel spinning for themselves.
- indymike 5y ago> People develop confidence and expertise from repeated success at accomplishing things. This works just as well, and has the benefit of not introducing bugs and security problems: "Thanks! I can merge this if you fix A and B." BTW - much better to get the flywheel turning in the right direction early. It is very hard to turn a gyro once it starts spinning.
- deleted 5y ago[deleted]
- mwcampbell 5y agoI feel the pull of perfectionism in my own Rust project [1]. Rust itself sets such a high standard of bending tradeoffs, trying to meet competing goals (and to some extent succeeding), that I feel like my own library project needs to meet that same standard of perfection. I fear I might have made more progress toward my actual goal by now if I had gone with C++. [1]: https://github.com/AccessKit/accesskit https://github.com/AccessKit/accesskit
- da39a3ee 5y agoNeither the PR, nor the linked issue, goes to any effort to explain what the work is and why it is needed. PRs should always have a carefully written intro, unless they are doing something totally trivial. For a new feature, the PR intro should explain the background and why the feature is justified, a high level overview of the code changes, and how correctness has been established. 30 minutes writing a PR is not much, especially if you've been working on something for more than one day. If your company doesn't have that culture, your company should change.
- thenoblesunfish 5y agoI use Alacritty exclusively, and knowing that the maintainer is discerning makes me like it even more. I'm getting what I signed up for, which is a project which cares deeply about doing a few things very well. I think that an unstated implication of that ethos is that there will be plenty of things that you would like to do, but upon some amount of investigation don't see how to do well enough, so you don't do them and move on to devote your precious time and energy to other things related to your code, which remains an enjoyable place to work. That looks like the story of that ligatures PR.
- nchudleigh 5y agoIn this camp, my tty needs are simple. Alacritty is simple- and works well. IMO core maintainers call the shots on what to accept and what not to. As others have mentioned, if you don't like it- fork and build your own.
- nixpulvis 5y agoI have the utmost respect for Chris. One thing I've learned from working with him a little bit was that there's a huge importance to both the medium and the timing of the message. Balancing even just IRC and GitHub PR comments is a tough game to play, but it must be played if you want to be successful. Treating PRs like IRC will get you in trouble, while reading IRC like a PR might leave you in the dust. Knowing when to move an argument from IRC to a longer form like a PR or Issue is a critical skill (one I never was very good at). Chris and team, if you happen to read this. Thanks again for all that you do.
- jwcooper 5y agoI agree with this as well. I use Alacritty all day, every day for work. It does exactly what I need and is very fast and stable.
- skrebbel 5y agoThis smells a lot of the classic "Worse is Better" discussion [0]. Back then, it was Scheme people insisting on correctness and C people insisting on pragmatism. It's no surprise to me that Rust, a language with a heavy focus on correctness, attracts the correctness-over-pragmatism crowd. The author is a "worse is better" programmer who finds themselves surrounded by "the right thing" people. I think the addendum the author adds a year later in the top comment is the right insight: fork away. This keeps the "the right thing" people happily obsessed with getting everything right, without the author being blocked on moving faster. [0] https://dreamsongs.com/RiseOfWorseIsBetter.html https://dreamsongs.com/RiseOfWorseIsBetter.html (1991)
- couchand 5y agoI've found Rust programmers to be eminently pragmatic. The economics of bugs have been clear for decades: it is orders of magnitude more expensive to find and fix bugs after they've been shipped.
- purple_turtle 5y agoAnd, additionally, if someone is unwilling to fix known issues in PR - then they will definitely not fix bugs in it after it become merged. So for maintainers merging PRs with known issue is basically promising to fix everything not finished.
- DarylZero 5y agoTo the contrary, a developer is MUCH MORE likely to fix bugs in merged code that has users, than in an unmerged PR. It's the users that give motivation to work on the project. Working on a PR is like working on spec. Working on the development branch gives you direct access to the "payment" of users using your code.
- purple_turtle 5y agook, there are two different effects in action: - creators are more likely to abandon or ignore projects that have low popularity or are completely unused - creators are more likely to be burned out when there are piles of demands, requests, complaints etc
- jpe90 5y ago"The only people entitled to say how open source 'ought' to work are people who run projects, and the scope of their entitlement extends only to their own projects. Just because someone open sources something does not imply they owe the world a change in their status, focus and effort, e.g. from inventor to community manager. As a user of something open source you are not thereby entitled to anything at all. You are not entitled to contribute. You are not entitled to features. You are not entitled to the attention of others. You are not entitled to having value attached to your complaints. You are not entitled to this explanation. If you have expectations (of others) that aren't being met, those expectations are your own responsibility. You are responsible for your own needs. If you want things, make them. Open source is a licensing and delivery mechanism, period. It means you get the source for software and the right to use and modify it. All social impositions associated with it, including the idea of 'community-driven-development' are part of a recently-invented mythology with little basis in how things actually work, a mythology that embodies, cult-like, both a lack of support for diversity in the ways things can work and a pervasive sense of communal entitlement." https://gist.github.com/richhickey/1563cddea1002958f96e7ba9519972d9 https://gist.github.com/richhickey/1563cddea1002958f96e7ba95...
- 725686 5y agoRich Hickey is spot on...as always.
- visarga 5y ago> you are not thereby entitled to anything at all. well, technically you are entitled to the source code
- jszymborski 5y agoI don't think F.Brennan (OP) is making any demands here. He's simply commenting on a pattern of forsaking the good for the perfect in a lot of repositories that, in his opinion, cause them to stagnate. I see no expectations, or demands in this post. Only disappointment at what OP sees as a missed opportunity. OP is a pretty prolific contributor to open-source, and I get that ones purview doesn't extend past ones owns projects, but it certainly affords perspective. I hardly think any of the comments in this post are anything OP or any project maintainer should take personally or as undue pressure. It's simply well-trodden commentary [0]. [0] https://en.wikipedia.org/wiki/Perfect_is_the_enemy_of_good https://en.wikipedia.org/wiki/Perfect_is_the_enemy_of_good
- coldtea 5y ago>Let's look at another project, alacritty. Don't we all remember it? It was supposed to bring Rust to the mainstream Linux desktop. It was supposed to be the new standard tty. It was supposed to be a revolution, shaking the foundations of the Earth No, it was just supposed to be one of the many projects with ambitious goals, that more often than not, go nowhere, and are abandoned a few years down the line... If you've been on the scene long enough, you've seen thousands like Allacrity: editors, shells, terminals, DEs, new languages, etc.
- nixpulvis 5y agoYou sound like you speak from experience. What makes for a project's success then? Is it the leadership? The raw motivation? How do you facilitate interest? Where are the developers and productive users coming together to talk? I ask because I don't know how long I've really been on "the scene" myself and I do truly still feel there's something special about projects like Alacritty and Rust. When I look around and compare tools, mostly, I see nothing but the same song and dance.
- coldtea 5y ago>What makes for a project's success then? I've seen a few factors play an important role: (a) dev's persistence - many projects come with grandiose goals, go some of the way, but the dev loses interest after 1 year or so and abandons them. (b) good marketing - many project are good and maintained well, but just don't market themselves nicely. A nice landing page, examples, documentation, screenshots, and even some superficial stuff like a nice logo and icon, all play quite a role in the success of one FOSS over another. It's not enough to welcome users/contributors, you also need to make yourself known well. (c) solving a unique need (this is not necessary - e.g. you can be "just another editor" and do well - but it's a big bonus if you have that. >I ask because I don't know how long I've really been on "the scene" myself and I do truly still feel there's something special about projects like Alacritty and Rust. About Rust yes. It has proven itself, shipped code in major companies, got books, wide adoption, even interest from Microsoft, Facebook, and others. Allacrity, I'm not so sure. A lot of big early claims, but still nothing special to write home about. It's also that Rust solved a real problem (memory safe, close to the metal, modern language), whereas Allacrity is just one of many terminals. And nobody really thought "what I need is a secure terminal" - as if terminals are a big security issue. A faster terminal sure, but there are several plenty fast terminals, with GPU support and everything.
- chrismorgan 5y ago(2020)
- nixpulvis 5y agoI was for, a period, a contributor to Alacritty and I'm still a daily user. The fact remains that it's a wonderful tool. Far better than most, yet still flawed in a number of ways. Both on the user side and within the codebase itself. That said, I couldn't keep up with the arguments and decisions, while also balancing my own (disintegrating) life. I feel that we are all suffering from the effects of others far too heavily these days, so much so that good projects like this are labeled a "tragedy". That is completely unfair blame. The tragedy is not of Alacritty, it's of us. It's our fault we haven't fixed the issues. It's our fault all the comments and messages are loaded with unnecessary emotion. Well... it's at least partially our fault. Sometimes it's true that the squeaky wheel gets the grease. Sometimes it's also true that dark powers work against us. Still we must look at our own part in the equation. Personally, reflecting on this post from the start of 2020, it's hard to think of anything but my own failings in the last years. But that too is not fair. It's something I must simply work to improve; like always. Leaving the world a better place than where I found it. I know there are amazing developers still working hard on important issues. It kills me that I'm not helping as I could be. It kills me that I'm often stuck, fixing bullshit issues and wasting time on things that are out of my control. But that's how it is now, and that's how it's been too, just perhaps to a lesser degree for a time, when everything clicked. Perfection and correctness and idealism are lofty goals. But realism and practice are required while on the hunt. Maybe one day a new puzzle piece will be found, snuggling seamlessly into place. But until then, (we try and we fail)*. Don't throw the baby out with the bath water. I beg you.
- epage 5y agoI've recently left a Rust project and the maintainer's perfectionism was one part. From my observation, the causes tend to be: - Maintainers spread thin, putting more of a burden on contributors - Some projects being critical and needing more attention and some taking themselves too seriously (dealt with a project whose CI took a couple hours for ~60 jobs because they exhaustively tested every combination. - Maintainers who haven't learned to distinguish the important from unimportant. - Contributors who don't realize their PR is a white eleplant (burdensome gift) - Contributors who jump in with a PR without first seeing if it aligns with the project. Most of this happens everywhere. Probably the more unique aspects to Rust are being spread thin, precedence of high quality crates, and that Rust gives a level of control that is addictive and effects other parts of projects.
- Mic92 5y agoYep. Second this. I also stopped contributing to rust-nix for the same reason. CI took forever. They wanted changelogs for everything but as soon as another PR was merged it would result in a merge conflict. Whenever I need a libc function not available in rust-nix I just add the abstraction to the project itself - this way I also don't have to care about someone else breaking my code by changing types.
- epage 5y ago> They wanted changelogs for everything but as soon as another PR was merged it would result in a merge conflict. I'm tempted to move to fragments that a changelog is generated from to avoid conflicts. I just haven't gotten around to exploring what tooling is out there.
- andrew_ 5y agoCommon theme in open source: contributor doesn't agree with maintainer feedback, becomes petty, takes ball and goes home. Most of the time this is solved by patience and leaving ego at the door. Or forking.
- a_rustacean 5y agoOpen-source maintainers should merge everything that _I_ consider reasonable, because _I_ know better than them! If they don't, I'll call it a tragedy.
- tayo42 5y agoThis is part of what i think is a problem with rust. Where all of these important features are left to volunteers in the community to come up with. A lot contributors seem to be unprofessional or hobbyist/amateurs. Like some of these issues in the pr really aren't "perfectionism". Then this guy trying to make projects look bad seems childish because he isn't that great at programming. Maintaining a open source project and being good at coding aren't really overlapping skills. Two years to merge something seems like a failure on both parts. The maintainers should have said something in the begging and set some expectations too.
- throwawayffffas 5y agoIt looks to me that the maintainers straight up don't think the feature is important. But the author seems to miss the fact that by making a PR he is actually creating a burden for the maintainers. They are not in anyway obliged to merge it or even look at it. If he actually cared and wanted to contribute he would look for bugs not for new features. The way I see it new feature development is a right to be earned in a codebase you can't show up and expect people to review the code and merge it because it would look great in your cv or because it takes care of that one use case you care about.
- the_gipsy 5y agoWelcome to FOSS, where we don’t just merge every single shitty feature by sheer enterprise-momentum. The fact that someone put in the effort, or spent man-hours, or “absolutely needs it ASAP”, does not outweigh the goals of the maintainers. This is the reason why FOSS survives the test of time so well. At least quite a bit longer than enterprise software, which commonly has to be rewritten next year.
- deleted 5y ago[deleted]
- kretaceous 5y agoAh, Alacritty. Reminds me of one this issue which I created a few months ago. https://github.com/alacritty/alacritty/issues/4731 https://github.com/alacritty/alacritty/issues/4731 EDIT: I used it for a while in Windows before I switched to Linux where I use Kitty
- mendigou 5y agoOff-topic: Someone mentions in the Github comments that Rust has "self-imploded". I get it's a joke, but have there been significant bad events in the last couple of weeks?
- purple_turtle 5y agohttps://news.ycombinator.com/item?id=29306845 https://news.ycombinator.com/item?id=29306845 "Rust Moderation Team Resigns" ?
- simion314 5y agoOther issue with Rust is that the community is unable to realize that a decent standard library or an endorsed optional library with most used functionality is needed, Rust/cargo is becoming the next node/npm. Some excuses are about "perfectionism" like "we can't add json in standard library because there is a microscopic change we are stupid and do it wrong and then we have to maintain it".
- deleted 5y ago[deleted]
- fb03 5y agojust fork and change whatever you need and build it. that's the magic of open source. if someday your own personal fork gets enough attention and the use case you implemented is solid enough, it'll pick up steam and will possibly get merged (or not) into upstream. but still, you are free to change and peruse whatever you see fit. you got a lot of work done for yourself for no effort at all. time to put in your own.
- 19h 5y agoI think open source should be like genetics: if you want a mutation that’s not going to be part of a project, fork it. If it’s important enough of a feature people will adopt it and it will coexist with the original project. If that convinces the original authors of the importance of a feature, you can merge and make the world beautiful again. If something is important to me but I have requirements that differ from the maintainers I usually maintain a fork even if I’m the only user of it. Sometimes it attracts people with similar needs and they build on top of my changes. Discussions in open source are a lot more discursive and mutually respecting when you’re offering to donate your work to the project because it helped fulfill a need that you had yourself, not only because it gave you a reason to invest time into it but also because you don’t usually invest time into things without a clear reason you needed that feature.
- woodruffw 5y agoThis post fails to speak to me on two fronts: * The `nix` crate is a cornerstone of the Rust development ecosystem: if you do anything that requires POSIX or various *nix-specific APIs beyond those wrapped by the standard library, then `nix` most likely provides a high-level and safe wrapper for them. Perfectionism is a virtue in this context, one that keeps large parts of the Rust ecosystem from accidentally consuming buggy code. The author unfortunately chose a particularly messy and bug-prone corner of the POSIX APIs to wrap, and ran into a correspondingly intensive review process. I've merged simpler wrappers[1][2] with no fuss. * Alacritty seems to work just fine. I switched to it about two months ago, after using nothing but (heavily customized) rxvt-unicode for a decade. Maybe it's because I don't use ligatures or images in my terminals (I thought we were talking about non-"toy" functionality!), but I haven't found myself wanting for anything beyond what Alacritty already does. And the scrollback seems to work nicely. To summarize: where's the tragedy? [1]: https://github.com/nix-rust/nix/pull/1342 https://github.com/nix-rust/nix/pull/1342 [2]: https://github.com/nix-rust/nix/pull/1331 https://github.com/nix-rust/nix/pull/1331
- kwolff 5y agoSome background, the author is Fredrick Brennan, the creator of 8chan.
- revskill 5y agoI think merged or not merged is not the problem here. It's about learning from each other, so it's a win-win. It's fine that your first PR doesn't get merged, just learn from other (reviews) and go on with next PRs. Just never give up.
- kopipe 5y agoHello— I'm the author of this post, I did not intend for it to receive wide circulation, and only have shared it in the past year with a few friends and MFEK users to explain my views on forking in Rust, why MFEK relies on so many vendorized crates etc. I added some more recent commentary to the comments of the Gist: https://gist.github.com/ctrlcctrlv/978b3ee4f55d4b4ec415a985e01cb1c9#gistcomment-3975534 https://gist.github.com/ctrlcctrlv/978b3ee4f55d4b4ec415a985e... I have also updated the Gist itself with a note: > I did not submit this to Hacker News and did not intend that this post would have high circulation but have no real problem with it being there or with it having such. I have [more recent comments below](https://gist.github.com/ctrlcctrlv/978b3ee4f55d4b4ec415a985e01cb1c9#gistcomment-3975534 https://gist.github.com/ctrlcctrlv/978b3ee4f55d4b4ec415a985e...). This post is from January 2020 and predates the Modular Font Editor K (MFEK) project. Cheers.
- ccchapman 5y agoMassive respect to the Alacritty team for holding true to keeping it the most reliable and performant terminal emulator. It is my daily driver and I am grateful for the high degree of care held within its community.
- oconnor663 5y ago> If you feel like the goals of Kitty are more aligned with your personal preferences, why not support Kitty, it's a great terminal emulator. For what it's worth, I think this is an incredibly healthy attitude for a project maintainer to take. There are a lot of ways to go wrong managing a software project, and this attitude is a good way to avoid a big subset of common mistakes. It comes with downsides, of course, but it's important to think about the upsides too.
- yencabulator 5y agocatting a file in kitty can delete files from /tmp [1]. I don't think Kitty's enthusiasm for merging features without thinking about them hard enough is a good way to go either. [1]: https://github.com/kovidgoyal/kitty/blob/2350952d054bcaf945aa975d1fbd897660960520/docs/graphics-protocol.rst#the-transmission-medium https://github.com/kovidgoyal/kitty/blob/2350952d054bcaf945a...