23 ms·
To add to your list: > Reviewer able to make tiny changes to the code without a further round trip to the developer. Things like "missing full stop here" or
by londons_explore 5y ago
To add to your list:
> Reviewer able to make tiny changes to the code without a further round trip to the developer. Things like "missing full stop here" or "Please put a comment warning about X here". Developer should get a heads up that their code has been merged with changes, just so the tiny changes don't go unreviewed.
- chii 5y agoi'm a bit ambivalent about this sort of idea - reviewers adding "tiny" changes without extra reviews could be a place where bugs leak in. what's tiny or insignificant might turn out to be big - that's why code is reviewed by multiple people! I think for style formatting, making it an auto-format step during commit/push is the "better" way. Codified formatting means you argue and hash it all out once and be done with it forever.
- londons_explore 5y agoNothing stops an organisation having standards what is sufficiently tiny to use the process... Eg.: "Touches comments and whitespace only". "Resulting compiled binary does not differ". "Variable and function renames are okay". etc. Remember that with the original developer still able to review, they can always rollback a change they weren't happy with.
- epage 5y agoI feel the hard part is putting automation around this. I loved it when I worked on a small, high trust team where we were comfortable with each person making the decision on whether it was safe to do a post-merge review or that it needed attention first with a pre-merge review. EDIT: Something I have liked at a couple of my company's was a "cowboy commit audit" where we allowed people to directly push but doing so would ping the code owners and they would have to review to clear the state. People understood they shouldn't but also understood when it happened.
- fivre 5y agoGithub suggestion comments usually do this pretty easily. You can prompt the submitter to accept a diff. It does have two annoying problems though: - You must use a browser editor, no attaching a diff you generated elsewhere. Anything more than 1 line is hell because Github's editor gives no fucks about running gofmt or whatever. - If you request a change, approve the PR, and then the submitter accepts your change, it dismisses your approval.