5 ms·

First issue I clicked on... https://github.com/OpenMW/openmw/pull/3176 https://github.com/OpenMW/openmw/pull/3176

Deukhoofd 5y ago
They did apologise for that to be fair. https://github.com/OpenMW/openmw/pull/3176#discussion_r728586532 https://github.com/OpenMW/openmw/pull/3176#discussion_r72858...
izietto 5y ago
I see a discussion but it's not too harsh to me. Do you come from a Western country? People coming from Western countries tend to be more demanding about discussion friendliness sometimes for my experience
- circularfoyers 5y ago
  Contrary to both your comment and the parent's, one of the project's developers (not sure they are the main developer, but one of them) admitted in the referenced pull request that they were too harsh in their response to the contribution: > Now I am rereading my first comment an see that it is too rude. I am sorry for that. I was in a bad mood when wrote this.
  - izietto 5y ago
    Yep and he apologized as you noticed, so I can't see anything too frightening to me.
- silicon2401 5y ago
  What countries would be less friendly in your experience?
  - izietto 5y ago
    Let me clarify that I'm not talking about countries and people, I'm talking about language. For example, English language puts "please" every time you are telling someone to do something, in my language (Italian here), you don't do that. If you are not a good English speaker (like me), you suddenly become someone who gives commands to other people in a rude way.
    - a1369209993 5y ago
      > English language puts "please" every time you are telling someone to do something As a native English speaker: no it doesn't. Whoever told you that was gaslighting you, a corporate-politically-correct shitheel, or both. (Or being sarcastic, or cargo-culting something they picked from one of the previous categories, or some other breakdown of communication.)
    - silicon2401 5y ago
      > People coming from Western countries tend to be more demanding about discussion friendliness sometimes > People I'm a bit confused, are you talking about people and countries or not? In your original comment you explicitly said "people" and "countries"
      - bee_rider 5y ago
        They are talking about the way people from these countries typically phrase things as a result of their native language, rather than trying to characterize the actual personalities of the people from these countries. We just add more friendly sounding little filler phrases in our speech and often phrase instructions/commands as requests in English. This doesn't make us fundamentally nicer or more reasonable, it is just a social convention.
        izietto 5y ago
        Thank you for explaining that at my place :) I wasn't even referring to "Western" countries, I mean I come from Italy, which actually is a Western country, and when I read native English speakers I notice many differences that I'll never be able to reproduce
  - HolidayguyNOR 5y ago
    I'm not GP, but many Asian cultures apparently have a much more blunt culture than many "western" countries.
- HolidayguyNOR 5y ago
  I agree. There are also huge individual differences. I have a military background and we generally don't "gift wrap" our feedback. "This bad because X" is constructive, helpful and to the point, and it doesn't mean that the person receiving the feedback is incompetent. Some people seem to take it that way. Accepting failure is integral to learning and growth, but a key part of that is identifying the weak points and learning from them. Edit: s/gift wrap/sugar coat
bsagdiyev 5y ago
I… don’t see anything wrong with that discussion?
- tauin 5y ago
  not to mention petrmikheev isnt even the main developer, let alone the lead of openmw, psi29a is.
Narann 5y ago
Direct for sure, but not rude. Someone want a modification to be merged and push a lot of template code giving a 3 line PR explanation. This kind of situation comes often in OSS, specially in C++ project and I wouldn't be surprised if OMW had a lot of PR like this. With this kind of PR, the maintainer have to go into each line and try to understand what the point because the original author didn't explain that much + it's C++ template and not everyone like that. This is not a excuse to be arsh or anything, another option would have been to put a tag "need clarification" and let the PR in a hole and force the author to motivates its modifications.
- hoseja 5y ago
  Not just a simple template, a template template, which is certainly quite obscure.
mmastrac 5y ago
I thought the parent comment up the thread was referring to the multiplayer fork rather than the main codebase but I could be wrong
- krageon 5y ago
  I was referring to the multiplayer fork, yes

They did apologise for that to be fair. https://github.com/OpenMW/openmw/pull/3176#discussion_r728586532 https://github.com/OpenMW/openmw/pull/3176#discussion_r72858...

izietto 5y ago

I see a discussion but it's not too harsh to me. Do you come from a Western country? People coming from Western countries tend to be more demanding about discussion friendliness sometimes for my experience

circularfoyers 5y ago
Contrary to both your comment and the parent's, one of the project's developers (not sure they are the main developer, but one of them) admitted in the referenced pull request that they were too harsh in their response to the contribution: > Now I am rereading my first comment an see that it is too rude. I am sorry for that. I was in a bad mood when wrote this.
- izietto 5y ago
  Yep and he apologized as you noticed, so I can't see anything too frightening to me.
silicon2401 5y ago
What countries would be less friendly in your experience?
- izietto 5y ago
  Let me clarify that I'm not talking about countries and people, I'm talking about language. For example, English language puts "please" every time you are telling someone to do something, in my language (Italian here), you don't do that. If you are not a good English speaker (like me), you suddenly become someone who gives commands to other people in a rude way.
  - a1369209993 5y ago
    > English language puts "please" every time you are telling someone to do something As a native English speaker: no it doesn't. Whoever told you that was gaslighting you, a corporate-politically-correct shitheel, or both. (Or being sarcastic, or cargo-culting something they picked from one of the previous categories, or some other breakdown of communication.)
  - silicon2401 5y ago
    > People coming from Western countries tend to be more demanding about discussion friendliness sometimes > People I'm a bit confused, are you talking about people and countries or not? In your original comment you explicitly said "people" and "countries"
    - bee_rider 5y ago
      They are talking about the way people from these countries typically phrase things as a result of their native language, rather than trying to characterize the actual personalities of the people from these countries. We just add more friendly sounding little filler phrases in our speech and often phrase instructions/commands as requests in English. This doesn't make us fundamentally nicer or more reasonable, it is just a social convention.
      - izietto 5y ago
        Thank you for explaining that at my place :) I wasn't even referring to "Western" countries, I mean I come from Italy, which actually is a Western country, and when I read native English speakers I notice many differences that I'll never be able to reproduce
- HolidayguyNOR 5y ago
  I'm not GP, but many Asian cultures apparently have a much more blunt culture than many "western" countries.
HolidayguyNOR 5y ago
I agree. There are also huge individual differences. I have a military background and we generally don't "gift wrap" our feedback. "This bad because X" is constructive, helpful and to the point, and it doesn't mean that the person receiving the feedback is incompetent. Some people seem to take it that way. Accepting failure is integral to learning and growth, but a key part of that is identifying the weak points and learning from them. Edit: s/gift wrap/sugar coat

bsagdiyev 5y ago

I… don’t see anything wrong with that discussion?

tauin 5y ago
not to mention petrmikheev isnt even the main developer, let alone the lead of openmw, psi29a is.

Narann 5y ago

Direct for sure, but not rude. Someone want a modification to be merged and push a lot of template code giving a 3 line PR explanation. This kind of situation comes often in OSS, specially in C++ project and I wouldn't be surprised if OMW had a lot of PR like this. With this kind of PR, the maintainer have to go into each line and try to understand what the point because the original author didn't explain that much + it's C++ template and not everyone like that. This is not a excuse to be arsh or anything, another option would have been to put a tag "need clarification" and let the PR in a hole and force the author to motivates its modifications.

hoseja 5y ago
Not just a simple template, a template template, which is certainly quite obscure.

mmastrac 5y ago

I thought the parent comment up the thread was referring to the multiplayer fork rather than the main codebase but I could be wrong

krageon 5y ago
I was referring to the multiplayer fork, yes