4 ms·

I'm at a crossroads for a hobby project I'm working on. I have a model for youtube video metadata. I have functions to do things like transform the metadata i

by piyh 5y ago

I'm at a crossroads for a hobby project I'm working on. I have a model for youtube video metadata. I have functions to do things like transform the metadata into display values to be rendered to template. Should that logic be a function that takes a youtube metadata model object, or a class method on the model to return display values? There are more functions of increasing complexity after this display function.

Daishiman 5y ago
I personally keep display functions away from business objects. You could do with a mixin, or a helper class.
- piyh 5y ago
  Thanks for the things to google, I've faked it till I made it and still have some knowledge gaps to fill in.
  - Daishiman 5y ago
    You didn't fake it, you're making it. Whether you learned along the way or had book knowledge or experience from before isn't something anyone will care about.
rajin444 5y ago
If you're not able to quickly answer it, I'd put it where you feel like you'd first look for it (where it feels natural) and move on - don't try to optimize too early. The correct answer is going to depend heavily on what your app is doing, how it's structured, etc, so providing a good answer from an HN comment is going to be really hard. It's ok to be "wrong", just make sure you're consistently wrong so when you need to refactor it's not so bad. Eventually the answer will become clear...and if it never does, you probably made the right choice and saved a lot of time :) FWIW, https://www.django-rest-framework.org/api-guide/serializers/ https://www.django-rest-framework.org/api-guide/serializers/ might be helpful - but DRF is also a lot to take in if you're not already comfortable with Django.
lastofus 5y ago
Sounds like you might have a View Model. One option would be to define this View Model that takes your Model in the constructor, then make this view model object available in the template context.

by piyh 5y ago

Daishiman 5y ago

I personally keep display functions away from business objects. You could do with a mixin, or a helper class.

piyh 5y ago
Thanks for the things to google, I've faked it till I made it and still have some knowledge gaps to fill in.
- Daishiman 5y ago
  You didn't fake it, you're making it. Whether you learned along the way or had book knowledge or experience from before isn't something anyone will care about.

rajin444 5y ago

If you're not able to quickly answer it, I'd put it where you feel like you'd first look for it (where it feels natural) and move on - don't try to optimize too early. The correct answer is going to depend heavily on what your app is doing, how it's structured, etc, so providing a good answer from an HN comment is going to be really hard. It's ok to be "wrong", just make sure you're consistently wrong so when you need to refactor it's not so bad. Eventually the answer will become clear...and if it never does, you probably made the right choice and saved a lot of time :) FWIW, https://www.django-rest-framework.org/api-guide/serializers/ https://www.django-rest-framework.org/api-guide/serializers/ might be helpful - but DRF is also a lot to take in if you're not already comfortable with Django.

lastofus 5y ago

Sounds like you might have a View Model. One option would be to define this View Model that takes your Model in the constructor, then make this view model object available in the template context.