4 ms·

I found IWYU pretty annoying, due to its tendency to also include transitive includes. Some of those often end up about implementation details and are much more

I found IWYU pretty annoying, due to its tendency to also include transitive includes. Some of those often end up about implementation details and are much more likely to be added/removed. But maybe the projects using it that I worked on were using it wrong?

johnnyapol 6y ago
I think it definitely can be a project thing. My experience with IWYU has been on very large codebases and I considered its ability to find transitive includes a blessing. The specific case where it shined for me was it made it much easier to identify the true impact of fileset changes on the larger codebase when it came to refactoring.
anand-bala 6y ago
If the issue is with including transitive dependencies that are in your own codebase, then you should annotate the public interface header to the implementation details with IWYU Pragmas [1] that export the implementation (for example [2]). If this is in third-party libraries, you can use IWYU Mappings [3] to map the "private" headers (usually the transitive include) to the public interface. An example that I use for the PEGTL library [4]. [1]: https://github.com/include-what-you-use/include-what-you-use/blob/master/docs/IWYUPragmas.md https://github.com/include-what-you-use/include-what-you-use... [2]: https://github.com/anand-bala/signal-temporal-logic/blob/8006f81c5505118cb368189e351c7e56c26f1445/include/argus/core.hpp https://github.com/anand-bala/signal-temporal-logic/blob/800... [3]: https://github.com/include-what-you-use/include-what-you-use/blob/master/docs/IWYUMappings.md https://github.com/include-what-you-use/include-what-you-use... [4]: https://github.com/anand-bala/signal-temporal-logic/blob/8006f81c5505118cb368189e351c7e56c26f1445/tools/pegtl.imp https://github.com/anand-bala/signal-temporal-logic/blob/800...

4 ms·

I found IWYU pretty annoying, due to its tendency to also include transitive includes. Some of those often end up about implementation details and are much more

by anarazel 6y ago

johnnyapol 6y ago
I think it definitely can be a project thing. My experience with IWYU has been on very large codebases and I considered its ability to find transitive includes a blessing. The specific case where it shined for me was it made it much easier to identify the true impact of fileset changes on the larger codebase when it came to refactoring.
anand-bala 6y ago
If the issue is with including transitive dependencies that are in your own codebase, then you should annotate the public interface header to the implementation details with IWYU Pragmas [1] that export the implementation (for example [2]). If this is in third-party libraries, you can use IWYU Mappings [3] to map the "private" headers (usually the transitive include) to the public interface. An example that I use for the PEGTL library [4]. [1]: https://github.com/include-what-you-use/include-what-you-use/blob/master/docs/IWYUPragmas.md https://github.com/include-what-you-use/include-what-you-use... [2]: https://github.com/anand-bala/signal-temporal-logic/blob/8006f81c5505118cb368189e351c7e56c26f1445/include/argus/core.hpp https://github.com/anand-bala/signal-temporal-logic/blob/800... [3]: https://github.com/include-what-you-use/include-what-you-use/blob/master/docs/IWYUMappings.md https://github.com/include-what-you-use/include-what-you-use... [4]: https://github.com/anand-bala/signal-temporal-logic/blob/8006f81c5505118cb368189e351c7e56c26f1445/tools/pegtl.imp https://github.com/anand-bala/signal-temporal-logic/blob/800...