16 ms·
Github really needs to allow people to disable the "Pull Request" tab on repos, to reduce the stigma around not accepting pull requests. https://github.com/isa
by phendrenad2 6y ago
Github really needs to allow people to disable the "Pull Request" tab on repos, to reduce the stigma around not accepting pull requests.
https://github.com/isaacs/github/issues/1191 https://github.com/isaacs/github/issues/1191 3 years and counting.
Some people are resorting to adding bots which auto-close PRs with a message like "Sorry, I'm not accepting PRs at this time", but that only triggers once the person has put in the effort to patch your project, at which poi t they may get annoyed to be suddenly told that PRs aren't welcome.
Best solution is to keep code somewhere other than github. Is sourceforge still around?
- tecnocriollo 6y agoGitlab is a nice option
- skohan 6y agoI've transitioned to gitlab for new projects about a month ago, and so far the experience has been great.
- Vinnl 6y agoIt might be me, but I don't see an option to disable Merge Requests in GitLab?
- dnsmichi 6y agoHi, GitLab team member here. You can find it in the project settings in the "sharing and permissions" section: https://docs.gitlab.com/ee/user/project/settings/#sharing-and-permissions https://docs.gitlab.com/ee/user/project/settings/#sharing-an... You can also disable the repository feature, and use the project for issue management only.
- Vinnl 6y agoHeh, got it - I was looking under "Merge requests" :) Thanks both!
- algo_cheese 6y agoIn your project "Settings" -> "General" -> "Visibility, Project features, permissions" -> "Merge Requests". IIRC, you must be owner of the project.
- SamWhited 6y agoWith apologies to the GitLab team, our views of how to make good software vary drastically and yours may be more in line with other peoples, but not mine: Maybe Gitlab's gotten better recently, but it's probably the most annoying piece of software I've ever used (well, second to Confluence maybe). It does everything which might be appealing to some, but for me it just meant everything was confusing, inconsistently labeled and documented, and/or buried under 5 levels of menus or under buttons that made no sense. The way I explain it is you know how when your computer illiterate parents ask you to do some simple task that you have literally no idea how to do, but you look at some menus that have vaguely similar sounding titles based on your years of building up intuitions about how computer UIs work, click those menus, find what you need and do the task? GitLab breaks all those intuitions so easy tasks become hard. YMMV, of course. I've been using Sourceforge recently and am pretty happy with it overall, though it's still very alpha quality.
- scaladev 6y agoI think you mean sourcehut: https://sr.ht https://sr.ht
- toyg 6y agoI hope so! If he really meant Sourceforge is alpha-quality after decades, I fear he'd forever be disappointed with the state of all software...
- hutzlibu 6y agoI hope so too, but mainly because sourceforge burned all reputation and trust for me, when they sneakily bundled adware to OSS installers.
- SamWhited 6y agolol, oops, yes, I did indeed mean sourcehut.
- ljm 6y agoI like GitLab but it has to be the only product I've used that gives you a different form of navigation almost every time you visit the site. Will it be at the top? Down the side? Tab based? Drop downs? Who knows!? Meanwhile, Github's UI is so stable (outside of the super infrequent redesigns) you basically develop a muscle memory for it.
- Communitivity 6y agoIf you are writing something to contribute it to a project, then you should discuss the idea with the current committers/maintainer on the project's mailing list, or discord, or however they communicate. If you don't, and you submit a PR, you should expect the PR to be closed with a "Unfortunately, this change was not discussed. As a result it may clash with other efforts underway, or our future roadmap. Also, not having discussed it prior to the PR increases the suspicion that you have not followed our coding guidelines. Consequently this PR is closed. Please propose the change on the mailing list and take part in the discussion before revising this patch and resubmitting the PR." Because of this I think an auto-close is fine. I also do think Github should allow disabling the PR tab.
- gus_massa 6y agoI agree, but I'd make an exception for fixing typos, obvious bugs and tiny additional features. Sometimes the change takes less time that discussing in other channels, and sometimes it's easier to explain with code if you are not a native speaker. I think that spending more of a weekend in a PR without checking before with the maintainers is a bad idea, because there is a big risk that is not merged and is a waste of time. Also, each project has it's own weird rules, like code style, space vs tabs, changing whitespace in unrelated lines, adding tests, ... and a long list. Some are written explicitly, and some are just implicit rules. So sometimes it's difficult to make a PR that follows all the rules.
- Communitivity 6y ago100% agreed. Things that are obvious to fix and have no design impact should be ok to PR and get accepted quickly. Every rule has exceptions, and this is definitely one for the rule I described. Thank you for pointing reminding me and clarifying.
- phkahler 6y agoYep. We had a PR for a single character typo. The submitter went to a lot of trouble, but the burden to the project really was as small as could be. No discussion, no open issue, just a PR with a one liner that could be reviewed in seconds and accepted with a click. Any other process would have been more work for the maintainers.
- pabs3 6y agoSourceForge is still around. I would suggest SourceHut over SourceForge these days though (not sure if SourceHut can turn off contributions).
- ddevault 6y agoSourceHut has you opt-in to anything you want - bug trackers, mailing lists for patches, git or hg repos, etc. The source code repository isn't the singular source of truth for a project like it is on GitHub. You can have a project with a dozen bug trackers, two mailing lists, and five source code repositories, organized in whatever way makes sense for your project.
- andrepd 6y agoThe flexibility is cool, but why would you want to fragment your bug trackers, for example, like that?
- JosephRedfern 6y agoI think this was just an example, really, but I know some projects have an external bug tracking tool to document customer-reported issues, and closed, employee only ones to discuss the issue internally.
- callmeal 6y agoSo you can have a separate one for "internal" and "external" customers perhaps?
- ddevault 6y agoSometimes it makes sense to have different bug trackers for each sub-product, but also one for support, and one for your infrastructure issues, and a locked-down one for security tickets, and maybe another for packaging issues - any of which may not have associated source repos. Whatver organizational model meets your project's needs best, you have the flexibility to apply it. And people often do! A lot of the projects on sr.ht, given this flexibility, haven't recreated the same model as GitHub shoehorns you into. It goes beyond bug trackers, too. One other detail is that different projects can share resources with one another. I use one mailing list to slurp up all patches for my smaller side projects into one place, for example.
- massysett 6y agoYes, for just this reason I am beginning to remove my projects from Github. I have "given back" by posting my Haskell libraries to Hackage, where they may be used and inspected by all. I'm not going to "give back" by maintaining software to the specifications of others, free of charge. This level of "giving back" is not trivial: I have often benefitted from seeing the source code of other projects and deciding I don't want to use the library, or seeing the code and deciding to modify it or take a different approach - or seeing the library and realizing that I wanted to try something similar, but this library shows me why I shouldn't do it. Maybe others will similarly benefit from seeing my stuff. If they see my stuff and think it's deficient, wonderful! Alter it to make it fit your needs, or use it as an inspiration for your own fresh rewrite. But I'm not maintaining software for other people. God bless people who do; that's wonderful. But it's perfectly OK to just post stuff up in case someone else wants to use it. When people see the code on Github they think "oh I can make feature requests" or "I can send a PR." Fair enough - Github is "social coding" after all. So I just won't put code on Github.
- cies 6y agoThis is important. We need some vocabulary definitions for all different levels/aspects of "open". Open Access, or not. Open for contribution... or not. Commit ownership transferals, or not. In some cases there are whole steering committees.
- mumblemumble 6y agoThe vocabulary is already there. What is out of place is the perception of where the defaults lie. Right now we seem to assume that, unless someone takes the time to write out rules explicitly saying what they're not willing to do, then they must be willing to do it. It should be just the other way around. If a project wants contributions, for example, then they can communicate that by posting contribution guidelines in the README.
- peteretep 6y ago> It should be just the other way around It should not be just the other way around
- chmaynard 6y agoIsn't that what archiving and mirroring are for? If you archive it or call it a mirror, GitHub users will understand that contributions to the repo are not accepted.
- kodah 6y agoKind of. Archiving means you can't commit to it either, from what I know. Mirroring doesn't necessarily mean that you can't contribute to it, it just means you can't contribute to it on GitHub.
- sudhirj 6y agoNo, archiving implies that no more code changes will be made. The author’s intention is not that that project is “finished”, it’s that they are the only ones going to make changes to it. Archiving will lock the authors out of making changes as well.
- qhwudbebd 6y agoI think archiving stops anyone pushing to a repo at all, but an option to label a repo as a mirror (and thereby block pull requests on GitHub) would be perfect for me - it pretty much exactly describes the situation for my GitHub repos. Your post implies this option exists, but I can't find it in the interface - am I missing something obvious?
- chmaynard 6y agoThis GitHub article may be useful: https://docs.github.com/en/github/creating-cloning-and-archiving-repositories/duplicating-a-repository https://docs.github.com/en/github/creating-cloning-and-archi... I'm not sure if a mirror repo actually blocks pull requests. Check with GitHub Support for more information: support@githubsupport.com
- qhwudbebd 6y agoThis article isn't about creating a repository with non-standard properties I'm afraid. It's just a set of instructions for copying one repository into another. The resulting repo isn't any different from any other Github repository and doesn't have any kind of 'mirror' status.
- bityard 6y agoI don't blame Github here, their WHOLE spiel is open collaboration for community software projects. If want to share your project online but don't want to engage with your users as peers, then GitHub was never the right place to post the repo anyway.
- jabbany 6y agoPretty sure the repo maintainer still wants to engage with users as peers (via bug reports and feature requests as they mention) just not through code contributions. In fact, if you only look at the "issues" framework, GitHub does a pretty good job of making things easy to use compared to the other bug trackers...
- trinovantes 6y agoDoesn't make sense they'd allow you to disable Issues but not PRs if they only cared about engagement
- SulfurHexaFluri 6y agoThis is rubbish. Github is massively more useful than dumping the source on your own webserver even if you do not want PRs. It would be a fairly simple change to simply add a button and remove the PR tab.
- toyg 6y agoGithub allowing you to disable PRs would be a bit like Facebook allowing you to opt out of ad-tracking...
- johannes1234321 6y agoI don't get the analogy. Also mind: Even if pull requests are off somebody else might emerge and maintain a fork, which becomes more successful. Maybe even going as far that that the original owner can safely outsource the maintenance of the thing he created.
- toyg 6y agoThe whole business model of GitHub is to get you to use its proprietary social features, so that 1) you get locked-in, and 2) you generate and maintain adoption virality. The minute they become just another dumb git host, their relevance disappears.
- sofixa 6y ago> 1) you get locked-in, How do you get locked in? PRs, once merged, are just regular commits. You lose the history and discussion around the PR itself, but that's all, but it's not like any alternative allows you to migrate ( e.g. the abomination that is using email for git collaboration is stuck in unreadable, unsearchable, unindexed emails somewhere; you can copy the data pretty much the same way as from GitHub, but both are unexploitable without a lot of tinkering / adaptation)
- enriquto 6y ago> Github really needs to allow people to disable the "Pull Request" tab on repos, to reduce the stigma around not accepting pull requests. I'm not the one to defend GitHub, but what's the big deal about not accepting pull requests? If you clearly state that you won't accept PRs and somebody still sends them, then you can close them right away and problem solved. Am I missing anything? Another issue is that the github pull request model is not very "gitonic". There are much saner systems like sourcehut.
- darkwater 6y ago> Am I missing anything? Yes. The "reduce the stigma" part. Having users open a PR to just get it automatically closed by a bot (which also needs to be set up) it's far less welcoming than NOT having at all a "Pull requests" tab where you can open said PR.
- enriquto 6y ago> it's far less welcoming Oh please, only somebody with a ridiculously thin skin would be offended by seeing rejected his PR to a project that clearly states that does not welcome outside contributions.
- onion2k 6y agoonly somebody with a ridiculously thin skin... People like that are very common and often very vocal.
- DangitBobby 6y agoDepends on how much work they put in, doesn't it?
- tombot 6y agoSurely someone invested enough to submit a PR would have read the readme which explains they won’t accept a PR
- rectang 6y agoIs it possible to "archive" and then "unarchive" a Github repo using the Github API? If so, one possible solution is to maintain the primary repo elsewhere (Source Hut, Gitlab. wherever), and run a sync routine on a cron (or perhaps every push): 1. unarchive Github mirror repo 2. Push changes from primary repo to Github mirror 3. archive Github mirror repo There's a race condition where someone might see the unarchived repo and start a pull request during the brief period where the sync is taking place, but the possibility that they'd both start and then fisish a pull request during sync periods seems remote.
- gregoriol 6y agoThe problem with archive is that it looks like "not maintained anymore"/"deprecated", which is not the case here.
- rectang 6y agoI agree, it's a hack. This hack competes with the "auto-close all pull requests" hack. Which hack you would choose depends on how important it is never to see pull requests (e.g. for IP reasons as described elsethread).
- fortran77 6y agoAmazon CodeCommit works great for me.
- bcfalconer 6y agoLike all of AWS, the pricing seems opaque and without hard limits: https://aws.amazon.com/codecommit/pricing/ https://aws.amazon.com/codecommit/pricing/ "Our transaction and storage quotas are designed to handle the most common developer workflows without incurring overages. For most workflows where CodeCommit users are manually using Git operations, these quotas are rarely breached." "$0.001 per Git request" I need an option that is limited to $5 a month, with DDoS being their problem.
- sofixa 6y ago> I need an option that is limited to $5 a month, with DDoS being their problem DDoS is always their problem. AWS and co always waive charges due to attacks or significant errors on user's part ( e.g. writing an infinite loop that results in a huge bill)
- macksd 6y agoI like the idea of reducing the stigma, but honestly if I haven't realized they don't accept PRs by the time I'm looking for the PR tab, I've already done all the same work, kinda for nothing. It ought to be made very clear in README.md or CONTRIBUTING.md or something too. I do wish people weren't completely closed to PRs though. I think companies are often misled when they think they'll get free labor out of open source, etc. and I think the free-as-in-libre aspect is more important relative to community aspect than a lot of people, but still - I hate it when my only option if I want a bug fixed is to wait for the company to do it themselves or fork. Even if I have to sign over all my rights of the code, I'd so much rather they at least consider taking my PR and be done with it. They don't have to do it for features they don't like or fixes that have downsides. But for a straightforward fix, at least look at it. It might be all the free help you ever get from the community.
- massysett 6y agoYou want other people to do work for you, for free. That's completely understandable.
- phkahler 6y ago>> You want other people to do work for you, for free. That's completely understandable. The parent poster was talking about submitting a Pull Request. In other words, contributing the work for free. I suppose expecting someone to look at it might be asking them to do something for free, but if that's a problem then I agree that Github should have the option of not having the button on a project at all. Or maybe you thought PR stood for Problem Report, in which case expecting it to be looked into by someone is an expectation of free labor.
- massysett 6y agoExamining the pull request is work, as is integrating it into the software and maintaining it in the future. The parent wants the project to do that so that s/he does not have to fork it him/herself. In other words, the parent wants someone else to do work, for free. Free Software is about the freedom of the user - freedom to distribute, freedom to study, freedom to use, freedom to modify. Somehow people have managed to pervert this so that it not only means "free as in free beer so that I can use it" but even "free beer so that OTHER PEOPLE can do work that I want done, for free." There is absolutely no entitlement to this.
- mathnmusic 6y agoDoes this not serve the purpose? Repo -> Settings -> Moderation Settings -> Limit to repository collaborators
- Footkerchief 6y ago"Disable pull requests while keeping issues"
- dbrgn 6y agoThis cannot be enabled permanently. Max duration is 6 months.
- _jal 6y agoSeems weird to me to blindly fire off a PR to a project I've never communicated with. I've always asked first, mainly because I don't want to waste my time if they won't give it any consideration. And also because maybe they're already working on whatever I was thinking of, or are doing it in a different way, or...
- publicola1990 6y agoThat ok, but there is also the thought that if you see a picture hanging in the wall is tilted, it is better to jt straighten it without waiting to ask permission. It is easier to ask for forgiveness than for permission.
- mhitza 6y agoMy contributions are fixes that I need now. So after I fix the issue for my usecase I fire off a PR upstream. As a maintainer you are free to close my PR, or work togheter with me to bring it in line with your project standards.
- Joeri 6y agoIf the contributing.md says no PR’s are welcome and there is a pull request template which just says in big letters “PLEASE DON’T!” I doubt many people would get confused. https://docs.github.com/en/github/building-a-strong-community/creating-a-pull-request-template-for-your-repository https://docs.github.com/en/github/building-a-strong-communit...
- Arnavion 6y agoHow does anyone even see the PR template? If you fork, push a branch with your fix to your fork, go to your fork in the browser and click the "Compare & Pull Request" button to make a PR from your branch [1], you don't see the template at all. The UI is auto-filled with the text from your commit message. I thought everyone filed PRs this way; is there another workflow I haven't heard of? [1]: It takes you to https://github.com/$upstream/$repo/compare/master...$you:$branch?expand=1 https://github.com/$upstream/$repo/compare/master...$you:$br...
- TheRealPomax 6y agoAlso the "fork" option. If you want the source, pull the official source, but there are plenty of projects where people should not be creating their own copy that is on equal footing as the authoritative repo.
- yawaramin 6y agoIt's a widely-known practice for companies to internally fork and vendor software they use.
- TheRealPomax 6y agoSure? But that doesn't mean you can't give people the power to turn off that "one-click, no thinky thinky effort effort" option.
- kminehart 6y agoIt's crazy to me that the open source world has completely standardized on a closed (and now Microsoft) product like GitHub. I'm sure someone would have implemented this feature for them by now if it was free software.
- Jkvngt 6y agoTo be fair, MS only bought GitHub after it became very popular.
- trynewideas 6y ago> Github really needs to allow people to disable the "Pull Request" tab on repos, to reduce the stigma around not accepting pull requests. It's more of a workaround than a solution, and depends on how much you trust GitHub Actions, but this one will autoclose all issues and/or PRs. https://github.com/marketplace/actions/repo-lockdown https://github.com/marketplace/actions/repo-lockdown > Best solution is to keep code somewhere other than github. Is sourceforge still around? Aside from Sourceforge and self-hosting (simply via gitweb, or with GitHub-like features in Gitea, Phabricator), there are the big ones like GitLab and Bitbucket, cloud repo services on AWS and Azure, and smaller/indie services like Sourcehut (sr.ht), Launchpad, and RhodeCode.
- pizzazzaro 6y agoThis is why our tools for Open Software need to be Open themselves. Have a problem being unable to disable PRs? A PR that fixes it would be embarassing for Github if it were simply Closed. How many such PRs for distinct code could we get submitted at once?
- whateveracct 6y agoI guess you can add a PR template that says "PLEASE DON'T SEND ME PRS"
- justaguy88 6y agoThere is https://sr.ht/ https://sr.ht/
- hutzlibu 6y ago"Best solution is to keep code somewhere other than github. Is sourceforge still around? " How about just stating in README about your PR policy in big letters? And if then people get angry because they were too lazy to read, .. well you cannot and should not please everyone. Anyway, and what bothers me with GitHub is Microsoft, even though so far I cannot really complain. At least they have not sneakily bundled adware with OSS installers, like sourceforge did. So they really lost all reputation and trust for me and are never a alternative again. I rather go with microsoft and that says something.
- didibus 6y agoYa Github just needs a way to disable everyone to create issues and/or PRs.