11 ms·
There's more serious reasons this file picker is broken. Here's a trivial to reproduce and obvious issue that's been there for several years now: 1. Open a di
by snvzz 6y ago
There's more serious reasons this file picker is broken.
Here's a trivial to reproduce and obvious issue that's been there for several years now:
1. Open a directory that loads slowly (e.g. one with thousands of files on a smb3 mount)
2. While the list is loading, select a file (but do not open it)
3. Wait for the whole list to load
Once the list finishes loading, the file on the very top of the list gets automatically selected (discarding your selection).
Thus, if you select a file and click open, in the time between you select and click open, the selection can auto-change and you'll end up opening something else than what you've selected.
It is this bad.
- keyle 6y agoRight. So typical bug of redrawing selection once the list is rendered. On the plus side it should be an easy fix?
- Qub3d 6y agoGiven that we've seen multiple examples in both TFA and other comments in the discussion here pointing to simple bugs that have A) been open for 10+ years and/or B) locked and closed as WONTFIX, I don't know if that "plus side" is valid here.
- ht85 6y agoLet's do another... Open any directory with 3+ items. As first item is highlighted, quickly hit <down arrow>, <enter>, <down arrow>. The 3rd item opens... There is a lag when hitting <enter> and the last <down arrow> is processed out of order :/
- buckminster 6y agoThis is bad but it's not unusual. There are similar issues in Firefox and Windows. Nobody gets UI asynchrony right. There are race conditions in everything. It's particularly noticeable with a slow computer.
- danaliv 6y agoI promise you people have gotten this right. I have a 198? Mac Plus on my desk that I can boot up and do this on and it will work properly. I’m having trouble even imagining the insane event-processing architecture that results in keystrokes being processed out of order. Edit: Alright, alright, forget the old computer. My new ones get it right too. All of which is a red herring, because the point is this behavior is ridiculous and never should’ve shipped.
- ivanbakel 6y ago>I’m having trouble even imagining the insane event-processing architecture that results in keystrokes being processed out of order. It's relatively simple: the picker executes file-opening asynchronously, and only checks which file was selected at some indeterminate point after enter is pressed. In the meantime, the down arrow input in the main GUI changes the selection. The keypresses are always in order. Whether or not that's the correct decision, it's not an inconceivable design. That example is probably one of the only times it would matter, since you would need async code that cares about some part of the file picker state.
- ballenf 6y agoWhy wouldn't the <enter> key interrupt or freeze the keypress queue? I don't think you need some advanced async logic to get this right. The only potential downside would be if people expected to be able to cancel the <enter> action. But that would be unusual, I think.
- ivanbakel 6y agoAs a rule of thumb: if you ever ask "why not", and the alternative you're proposing is more complicated - that is normally why not. Lots of UI/UX bugs can simply be attributed to the programmer taking the most simple possible design. In this case, the async logic is not advanced. In fact, I'm willing to bet that this is what happened: at first, the file-opening was synchronous in the GUI. People complained that opening certain files locked up the file picker, so a developer sticks the file-opening code in a background thread. This produces the above bug, without complicating the input design - in fact, preventing the bug requires making additional changes to the code in some way.
- tomsmeding 6y agoIncidentally, that lag is there independent of how fast your disk is, it seems. It's kind of annoying.
- formerly_proven 6y agoThat's likely the fault of the GVFS and other virtual-fs-on-top-of-kernel-VFS layers. Gtk seems to be slower than others (such as KIO/KDE), but all of them are pretty slow. E.g. the KDE file picker takes about a second or so to finish listing the contents of my home directory (though it is usable while it is doing so, unlike the Gtk dialog), where the Gtk takes quite a bit longer (perhaps on the order of 3-5 seconds). Meanwhile ls is essentially instant, as you'd expect for just a few thousand files or so.
- ubercow13 6y agoKIO is pretty fast I think. Dolphin is insanely fast at least - if you list a large directory almost everything that can't be loaded instantly is loaded asynchronously and streamed in to the UI after the UI becomes responsive. I think the KDE file picker is using other code altogether, I'm not sure why it's so much slower. GIO is horribly slow and makes everything that uses it next to useless, eg [1] [1] https://github.com/lxqt/pcmanfm-qt/issues/462 https://github.com/lxqt/pcmanfm-qt/issues/462
- InfiniteRand 6y agoInteresting explanation at the end of the bug report: The slowness is only caused by the GIO's G_FILE_ATTRIBUTE_STANDARD_CONTENT_TYPE and g_file_info_get_content_type. Wherever they are used, there will be a slowdown because the contents of files, that lack extensions, should be read for finding their mimetypes. Almost all the time is taken by that; the other operations are done pretty fast — particularly, the Qt GUI takes no time in comparison.
- ubercow13 6y agoYes, actually reading that it makes it sound like the file manager itself is just badly architechted - of course you shouldn't load mimetypes synchronously before listing a folder in the UI, that seems obvious. So maybe I'm not right about GIO as such. But Nautilus is also excruciatingly slow despite being more fully asynchronous.
- j1elo 6y agoAssuming an asynchronous UI programming model, I can only conceive this happening because they skipped having a proper Model and instead the View is accessed directly (in the Mode-View-Controller way of thinking). However the most disturbing thing is that events might get to be processed our of order. Even if you stored current state in a proper Model, there is nothing you can do if your event queue ends up being "<down>, <down>, <enter>". I guess that's why Qt prefers to do all UI event processing exclusively in a single thread. The event queue will always be serviced in order.
- MawKKe 6y agoMany years ago I was a hit by a bug in the Gnome file chooser (on ubuntu) that selected a random sibling file in the same directory. Caused me to accidentally upload something I definetely didn't want to publish. In fact I have never since directly uploaded anything from my own personal file directories, instead I make a copy of it under /tmp for the upload process. Not sure if this is the same bug you are talking about
- enriquto 6y agoEven worse is when you know the exact file name that you want to open, and the interface fights against you writing it! For example I want to open /tmp/a.png, but there's thousands of files on /tmp and the cursor disappears while "loading" them, and and some characters of the file name are lost, or typed on different parts of the interface.
- kaszanka 6y agoRecursive search instead of type-ahead search within one directory in the file picker is criminally terrible. I don't think there is any implementation of a file picker that behaves like this (other than Gtk's).
- skrap 6y agoIs this https://gitlab.gnome.org/GNOME/gtk/-/issues/2366 https://gitlab.gnome.org/GNOME/gtk/-/issues/2366 ? It really bothers me as well.
- kaszanka 6y agoYes. As you can see, this is by design.
- philsnow 6y agoThis is in my experience emblematic of GNOME in general. I've shaken the dust off my sandals and don't use anything gnome-y if I can avoid it. Here's the thing that convinced me, a while back: https://wiki.gnome.org/Attic/GnomeScreensaver/FrequentlyAskedQuestions#Why_doesn.27t_the_screensaver_preferences_tool_allow_me_to_change_the_settings_for_the_theme.3F https://wiki.gnome.org/Attic/GnomeScreensaver/FrequentlyAske... I'm sure there's people here who are long-time contributors and/or supporters. Just ignore me, I'm not your target audience. ... I'm really not sure who your target audience is, though.
- Renevith 6y ago
- formerly_proven 6y agoPicking directories has been pretty broken forever as well. Say you start in ~/Downloads/foo and want to store the file in ~/Downloads, then navigating up will have "foo" selected, with usually no blank space to un-select (so you'd need to do ctrl+click or something to that tune); clicking "Save" (or whatever) will then descend into that directory instead of saving, so just using the mouse, or not using any shortcuts, you really can't do this. This, other UX and even performance (!) issues that have been mentioned in siblings as well as TFA makes the Gtk file pickers easily one of the TOP10 reasons to avoid Gtk and Gnome for anything. The interaction design of these dialogs is simply shit. Windows (and also KDE, which has been using a copy of the Windows dialog for about 20 years) show how to do it correctly.
- tylermenezes 6y agoWow I never thought about Ctrl+Click to deselect in that situation. I've probably wasted at least an hour of my life by giving up and re-opening the window in a different way. Thanks! (I actually asked someone more knowledgable about this once and was told that it's my fault for using the file picker incorrectly and I simply need to stop doing that.)
- formerly_proven 6y agoCan't take credit for that — someone told me to use ctrl+click in this situation after I ranted about it elsewhere.
- tsukurimashou 6y agoOne thing I was happy to discover as a kid was shift + tab to go backwards with input selection (Spacebar to trigger checkboxes was nice too)
- jfim 6y agoThese shortcuts have been a thing for quite a while too, they come from the IBM CUA guidelines [0]. [0] https://en.m.wikipedia.org/wiki/IBM_Common_User_Access https://en.m.wikipedia.org/wiki/IBM_Common_User_Access
- dheera 6y agoAlso if you are in the "Recently used" tab you can't hit Ctrl+L to get a path box
- benlivengood 6y agoGUIs should effectively be finite state machines and people expect them to operate that way. People understand latency and get used to it; it happened on mainframes and other terminal applications and people memorize the state machine and can tab and type through an interface at high throughput anyway. One of the most frustrating experiences is related to the OP; reflow in browsers as new elements load making it impossible to click on the right thing until the whole page finishes loading. Popups are also nearly as bad but maybe less avoidable.
- intricatedetail 6y agoSome folks use this fact to place ads in such way that when you want to click something by the time your finger taps the screen there is an ad underneath. So annoying.
- tylerjwilk00 6y agoIndeed. An even more nefarious Dark Pattern [1] if the have a listener on the "mouse down" event and use it as the trigger. [1] https://en.m.wikipedia.org/wiki/Dark_pattern https://en.m.wikipedia.org/wiki/Dark_pattern
- tapland 6y agoThat's not even a dark pattern, that's eqvuivalent to the link pointing to the ad all along =/
- tsukurimashou 6y agoThis is the worst, a french website Leboncoin (craigslist basically) does this, makes me want to murder the people behind it When you click next page nothing happens long enough to make you think your click hasn't been registered, then right as you click again the page loads with ads right where the button was
- speedgoose 6y ago
- juskrey 6y agoOn nearly every OS I know (now I am on MacOS): 1. System boots up and starts some apps which are creating windows. This may take some time. 2. While all of that loading, I am seeing some of the apps of no use, I am quickly switching to one, capturing focus, and pressing the quit shortcut. 3. Between my reaction and actual button press, some other app loads, and focus is switched to its window. 4. My keypress goes into another focused window, which gets closed instead of original one. Tada. Why OS focus has a priority over user focus?
- whywhywhywhy 6y agoI get this all the time with Safari windows on Macs ever since they changed the new tab view when they switched to location naming rather than big cat. Hit cmd+new window pops up with search highlighted, start typing after a split second the window pops behind the other and all the key presses are then fed into the previous window.
- amlib 6y agoThe gnome file picker is so bad that I will pretty much always load files by drag and droping files into the application from a file browser!
- circularfoyers 6y agoThis is pretty much how I've resorted to solving the issue for myself as well. It's a shame when I personally like GNOME in most other ways.
- j1elo 6y agoIt's stuff like this that makes so hard to onboard new non-techie users. The proverbial mom or grandma, whose knowledge about the "filesystem" and "directory hierarchies" is already pretty weak, would probably spend 30 minutes or more with this exercise in frustration, before giving up and/or grabbing the phone to ask for help. When you're past the stage of first impressions, it's a death by a thousand cuts. Windows is not better in lots of these details, but at least users already know its tricks due to Microsoft's years of desktop dominance. I'd argue the effort of changing platforms should be about improving the experience, not about swapping a list of UX issues with a set of different ones, otherwise the change isn't really worth it for most users. EDIT: oops I meant to write this comment as a reply to the sibling that talks about how difficult it is to select a parent directory in the file picker dialog (https://news.ycombinator.com/item?id=25721368 https://news.ycombinator.com/item?id=25721368)
- sam_goody 6y agoKDE user here, so cannot comment on this case exactly, but in my experience the default "Windows" of Windows and Mac are also terrible. Try to split a window pane on Windows, or right-click and create a file in Mac. In either, try to open an SFTP folder as if it is local, or integrate Git status icons into finder (all easy to do on KDE and Gnome). Good Luck. The number of copy+paste bugs and QuickLook hanging issues on Mac is not even funny. Just look at all the enhancers like Norton Commander and Path Finder, and you can see that even calling the OS Windows didn't make MS put too much effort into their windows.
- neop1x 6y agoThere are also multiple file pickers (Qt/GTK) and they don't share history or recent file list. Also in GTK picker if I select an existing file on Save by accident, I can't unselect it and I have to write filename again manually myself or close the picker and try again. This is annoying, time-consuming and frustrating. File pickers are one of the things I don't like on GNU/Linux unfortunatelly, saying that as someone who daily uses it as a primary platform. MacOS and Windows file pickers work better.