3 ms·
I'm skeptical about it's high claims. Looking at the code its just using the Go standard library image package, looping over the bounds and calculating delta?
by donatj 6y ago
I'm skeptical about it's high claims. Looking at the code its just using the Go standard library image package, looping over the bounds and calculating delta?
Doesn't seem like there's anything special here? It's roughly what any novice would build if asked to diff two images in Go?
- kripke 6y agoI just skimmed through the code, but as far as I can tell, the main point is that this code is multi-threaded. Which, sure, gets the job done faster than the single-thread `odiff` on a single image, but is quite irrelevant for a tool marketed for tests/CI where many images are likely to be compared in parallel already (and maybe a single core is even available).
- oefrha 6y agohttps://github.com/n7olkachev/imgdiff/blob/9b2a87e1b729c70b5d702cb9309a46b58ebd0190/pkg/imgdiff/imgdiff.go#L37-L38 https://github.com/n7olkachev/imgdiff/blob/9b2a87e1b729c70b5... Yep, uses as many goroutines as the number of CPUs, that's about it. Saying it's 3x faster or whatever in "benchmarks" without even saying what CPU is used in the benchmarks is just sketchy.
- esimov 6y agoI just looked at the source code and I'm very skeptical about what the author claims. The way the code is structured and is written is not very professional. Also I don't see any benchmarks. If you claims something at least give valid sources.