4 ms·
> We only really care about the end result of a Pull Request (in the context of Github) Hmm, I'm not sure that's true. Imagine if this excellent commit got squ
by MonadIsPronad 6y ago
> We only really care about the end result of a Pull Request (in the context of Github)
Hmm, I'm not sure that's true. Imagine if this excellent commit got squashed, there'd be something really lost: https://dhwthompson.com/2019/my-favourite-git-commit https://dhwthompson.com/2019/my-favourite-git-commit
- imtringued 6y agoSquashed into what? If someone submits a PR with only one commit then squashing does nothing.
- deleted 6y ago[deleted]
- kevinherron 6y agoYes, and that excellent commit would make an excellent PR all on its own. It’s entirely self-contained and should not be lumped in with some other change, so there is no reason it would be squashed in the first place.