4 ms·

Fail2ban is a bit shaky when it transitions to Python3. Hasn’t pass the pylint,?futurize, or 2to3 by much. But if the maintainers are willing, I can do those

• oefrha 6y ago
  Not sure what you mean by shaky, fail2ban has been working under Python 3 for quite a while. (See for instance fail2ban on Ubuntu 16.04 depending on python3[0].) People definitely would have noticed. I saw your issue[1] on GitHub, and that's just a misunderstanding of how fail2ban was ported to Python 3. fail2ban uses the use_2to3 feature of setuptools.setup to do automatic translation upon installation.[2] While I do wish the code runs under Python 3 as is, what users actually run is totally working code. [0] https://packages.ubuntu.com/xenial/amd64/fail2ban https://packages.ubuntu.com/xenial/amd64/fail2ban [1] https://github.com/fail2ban/fail2ban/issues/2853 https://github.com/fail2ban/fail2ban/issues/2853 [2] https://github.com/fail2ban/fail2ban/blob/960e30cfcdae7e2c81f74046efdbff1606f9774e/setup.py#L178-L182 https://github.com/fail2ban/fail2ban/blob/960e30cfcdae7e2c81...
  • egberts1 6y ago
    Yes. It may be totally working code. But it wasn’t written cleanly as many tools would attest.
    • viraptor 6y ago
      Those tools tell you if you comply with some persons style choices, and maybe catch a few potential problems. That says close to nothing about cleanliness or correctness. They're for internal use, not for making external measurements of code.