6 ms·
Hacking up a fix for the broken AppleTalk kernel module in Linux 5.1 and newer
- jhallenworld 6y agoIf you want this fixed forever, a regression test needs to be created for it. I have no idea how this works for the Linux kernel, but Google search reveals this project: https://lwn.net/Articles/625969/ https://lwn.net/Articles/625969/
- saagarjha 6y agoAh, stripping the signature from a binary you have modified. Glad to hear that others get to enjoy this previously mostly macOS-unique diversion now ;)
- ficklepickle 6y agoThat was a really fun debugging ride. I've never really had to debug kernel stuff before, so I also learned some things. Then you topped it off with some serious hacks. You sure know the way into my heart. Thanks for writing about it! While I don't have a personal use for AppleTalk support, it makes me happy that support for old protocols lives on.
- tyingq 6y ago"In this case, someone submitted a patch 10 months ago and was asked to tweak the patch. Then life got in the way (I totally understand), and he finally tried again about 9 months later... He was also asked to tweak the second patch because of a minor style issue (which I also understand). A third try at submitting the patch hasn’t been attempted as of this writing." I've been there. I understand both sides, but it's a bit frustrating from the "outside contributor" standpoint sometimes. For example, I use git quite a lot, but not GitHub. As a result, a pretty simple "couple of lines" fix I tried to contribute remains uncommitted because I wasn't able to format things in a way that made the target project folks happy. The pull request remains sitting there. Though I still occasionally get "thank you" messages from people that accidentally find and use it. So, some number of folks lose out on a good fix roughly because what would take me several hours, but take someone else a few minutes, just doesn't get done. Some sort of web based "force this minor tweak for a pull request" feature might have a decent upside.
- stormbrew 6y agoIs there some kind of cultural reason in the process of submitting patches to linux that someone else couldn't come along and, while giving due credit, do the style fixups on one or the other of the patches themselves and submit that as a v3/v2? Like, why should every attempt start from scratch as people lose interest?
- tyingq 6y agoYes, that's roughly the jist of my comment. There are often people with the skills to fix stuff that want to contribute back. But, there's typically a line for them. They fixed it for their own purposes, but are only willing to invest so much time in learning and aligning to project wishes and practices. I get there are opposite examples of contributors just being contrary and rude, but some sort of workflow to quickly make good, but standards-flawed fixes compliant has merit. Your idea of a simple way to let someone else take over a pull request seems good.
- saagarjha 6y agoIn general, a lot of contribution workflows are fairly daunting to newcomers–when I tried to submit a fairly small patch to the Linux kernel it took me a while before I figured out what to do, and even then I messed it up and it didn't end up going in. (Full disclaimer: I commented about it here and someone was extremely kind in sending me resources on how to actually do this. I haven't yet followed that advice, sorry!) But even with this, it's still really complicated to figure out how each project does things. I understand many don't really care about one-line patches, but it would be nice if this kind of thing (which I personally consider "outreach") was better supported.
- tyingq 6y agoBravo. Sometimes those one-line patches are gold. I still use a one-line patch for a popular Perl serial/rs-232 module that some kind soul tried to contribute, but failed to get accepted. It's been that way for 10 years or so.
- userbinator 6y agoThe problem here is that Ubuntu’s kernel modules are signed. It's easy to bypass, as the article shows, but also sad that this user-hostile practice has spread to Linux. I'd expect this for Windows or Mac, but not Linux.
- Jonnax 6y agoIt's not a user hostile practice if you have control over it. Do you consider signing keys in apt packages to also be user hostile?
- maallooc 6y agoIs there an advantage to enable AFP on my NAS? I have a Macbook but smb seems kinda shady there.
- ianlevesque 6y agoNewer macOS prefers SMB3 over AFP, even for time machine backups. There’s no reason to use AFP anymore on a modern Mac.
- duskwuff 6y agoAnd you don't even need the AppleTalk module for AFP. (I don't think modern macOS even supports AppleTalk anymore.) AppleTalk only comes into play when you're dealing with really old Mac systems which didn't support AFP-over-TCP yet.
- joezydeco 6y agoWhat hardware do you use to connect the two?
- rjsw 6y agoAll the things described are running over ethernet, there isn't any special hardware. The kernel module implements the stuff described in the sections on EtherTalk and AppleTalk phase II on this [1] wiki page. [1] https://en.wikipedia.org/wiki/AppleTalk https://en.wikipedia.org/wiki/AppleTalk
- rjsw 6y agoAppleTalk works fine on NetBSD. Doesn't require some long process to fix anything that breaks.
- rjsw 6y agoMy point was that maybe the Linux development process isn't a good match for niche areas like this. With NetBSD+pkgsrc, I can (and have done) just commit fixes to the kernel and userland AppleTalk code directly without needing to go through gatekeepers who may not have used this feature. The blog author might want to look at a recent pkgsrc patch to netatalk 2.2 that makes it work with current CUPS.