3 ms·
I try to just make it explicit. I'm quite happy to something and say "I don't like how you implemented A but that's a personal preference. Section B is a code s
by yjftsjthsd-h 6y ago
I try to just make it explicit. I'm quite happy to something and say "I don't like how you implemented A but that's a personal preference. Section B is a code smell but non-blocking. You need to fix C because it'll break prod in a way that tests don't yet catch. I'm willing to let you leave D as-is if you can explain why you did it like that."
- Supermancho 6y agoI also split my comments by issue to allow for more nuanced discussion. I try to make nitpicks clear as nonblocking in when there is a milieu.