3 ms·
> Nitpicks are what they are, and shouldn't block a PR in the first place, so not sure how much benefit this would be. I will often make a hedged critical comm
by Supermancho 6y ago
> Nitpicks are what they are, and shouldn't block a PR in the first place, so not sure how much benefit this would be.
I will often make a hedged critical comment, but approve the PR. I am capable of identifying my own "nitpicks" that are not functionally relevant. This allows me to provide my opinion, and track examples of where my opinion on a particular subject could have been applied, while not mucking up the process with a minority view.
- yjftsjthsd-h 6y agoI try to just make it explicit. I'm quite happy to something and say "I don't like how you implemented A but that's a personal preference. Section B is a code smell but non-blocking. You need to fix C because it'll break prod in a way that tests don't yet catch. I'm willing to let you leave D as-is if you can explain why you did it like that."
- Supermancho 6y agoI also split my comments by issue to allow for more nuanced discussion. I try to make nitpicks clear as nonblocking in when there is a milieu.