3 ms·
Couple things that stood out: code is not in a "src" folder separate from configuration. Views have just an "html" file extension - usually you would at least h
by winrid 6y ago
Couple things that stood out: code is not in a "src" folder separate from configuration. Views have just an "html" file extension - usually you would at least have the templating language extension there too. Didn't see any indication of test coverage. Also it looks like you have your own test runner?? Using Jest for ex. gives you a lot.
First thing in the readme is lines of code. I would start with what this is, what problems it solves, and why it's better than the alternatives.
- mongojunction 6y agoGood feedbacks. those all sound like changes I'm happy to make. If you want to contrib I'm happy but don't expect that from you at all obviously.
- pdubs1 6y agoI agree. Awesome project. The only suggestion I'd have is organizing the code files. The root folder is full of stuff-- from "helpers.js" to "permissions.js" to "index.js" to stuff about views and tests. If these aren't closely related, I'd personally set them into separate folders to organize main functionalities. Also, I'd prefer to see route separated out of the index.js folder, personally. I'd keep index.js as minimal as possible-- just the main server config stuff. I'd also remove the underscore prefix on the folder names, but that's only b/c I think most people use underscores unnecessarily. Anyway, it's just minor stuff. It's awesome to see what you've built OP.