5 ms·

"The fastest and safest AV1 encoder." quick search on unsafe: https://github.com/xiph/rav1e/search?q=unsafe&unscoped_q=unsafe https://github.com/xiph/rav1e/sear

by Thaxll 6y ago

"The fastest and safest AV1 encoder." quick search on unsafe: https://github.com/xiph/rav1e/search?q=unsafe&unscoped_q=unsafe https://github.com/xiph/rav1e/search?q=unsafe&unscoped_q=uns... https://github.com/xiph/rav1e/issues/2378 https://github.com/xiph/rav1e/issues/2378 https://github.com/xiph/rav1e/issues/2310 https://github.com/xiph/rav1e/issues/2310 Does not seems safe at all, definitly not the "safest"encoder out there.

dan-robertson 6y ago
The rust standard library is full of uses of unsafe. Does that mean it is not a safe library? No one uses “unsafe” in C (because it doesn’t exist). Does that mean C libraries are safe? Is there some safer encoder you have in mind?
weinzierl 6y ago
Just because the source has unsafe blocks doesn't mean it is unsafe either. At least the amount of work to check these blocks for memory issues is a lot less then checking any other implementation.
IshKebab 6y ago
Aren't the only other encoders written in C?
- mcraiha 6y ago
  SVT-AV1 is written in C (and lots of assembly). libaom-av1 is written in C (and lots of assembly). libgav1 (which is decoder) is written in C++ (and lots of assembly). So yes, lots of C/C++ in open source AV1 encoders/decoders.
  - IshKebab 6y ago
    So it sounds to me like it might be the safest encoder... except for the fact that it is 60% assembly. Maybe they can improve that.