3 ms·
I wholeheartedly agree, to a point. Sometimes hideously complex things look so easy because really smart people came up with a particularly elegant solution, so
by kstrauser 7y ago
I wholeheartedly agree, to a point. Sometimes hideously complex things look so easy because really smart people came up with a particularly elegant solution, so any rando off the street sees it and figures they could reproduce the thing.
However, I worked for a company who had a whole team of engineers and QA people working for months on what was basically a Django CMS, but with a large dose of "not invented here"-driven writing of everything from scratch. I'd finally gotten tired of it, so I spent a weekend at home implementing it in Django and being done with it.
I did learn two very important lessons, though:
- The other stakeholders really did not like someone demonstrating a working prototype of something they'd been doing unsuccessfully for months, and I got a thorough chewing out for disrupting their processes.
- I really didn't want to work for such an organization, and was much happier after moving to a smaller, more nimble company.
- potta_coffee 7y agoI came to a new company and built a working prototype of something in a few weeks that apparently, a whole team had failed to do in more than six months of struggling. I didn't know that the project had already been attempted. Some people really didn't like me after that.
- deleted 7y ago[deleted]
- munchbunny 7y agoFrom my experience, when I'm working on real world problems of nontrivial sizes and I see a big chunk of well organized, like a really well organized service, almost always it's because that was the latest cleanup/refactoring effort that happened after many years when the problem space was a moving target, and finally it stopped changing long enough to come up with a clean abstraction. The cleanest code I've ever written has always been on the second or third try. Write it once, test it against the real world, then rewrite it to take the new discoveries into account. It's too bad we rarely have the luxury of breathing room to rewrite things.
- kstrauser 7y agoI wholeheartedly agree. This was a brand new project, though.
- munchbunny 7y agoIndeed, upon reread I think I responded to what I thought you said, not what you actually said. Anecdotally, "not invented here" is consistently the most egregious source of unneeded complexity I've seen in my career.
- stevens32 7y agoI think it might be cause no one really knows what you're building until it's been built. Only until then (or even a little later) does the structure of the thing become apparent. Until you've got something most people agree is what everyone wanted, requirements are basically mush and so the code is too.
- therealdrag0 7y agoThat's a really good point. The cleanest code I've ever written (and got complimented on by others) was when I was the main dev on a rewrite of a legacy system. It's easy to focus on clean/well-tested code when you don't have to worry about business decisions and customers' main concern is that nothing changes, even existing bugs!
- Aeolun 7y ago> The other stakeholders really did not like someone demonstrating a working prototype of something they'd been doing unsuccessfully for months, and I got a thorough chewing out for disrupting their processes. They aren’t there to solve problems. They’re there to receive their paycheck :/
- distantaidenn 7y agoThis. At my previous company, the primary product was painfully simple in concept -- just a standard two-sided marketplace. The day I joined, one of the engineers told me to brace myself for the codebase. I figured it couldn't be too bad, after all, it was just a Rails app. Whew boy, was I ever wrong... The code was needlessly complex in the worst ways. I'm talking constructors to create constructors, ill-named models that belied their true purpose. The entire thing was a self-referential mess of spaghetti. No one really knew how the whole system actually worked. The app probably had over 400 models, and half of which were probably obsolete. It was obvious that over the years, no one ever took the time to clean up the code, and people just kept pouring more mess on top of it to meet deadlines. With such a messy codebase, even the smallest change that should have taken hours would take days or weeks.
- zimpenfish 7y ago> really did not like someone demonstrating a working prototype In my long and painful experience in software development, almost no stakeholders like being shown they've wasted time and effort on something even if they were told from the start it was a waste. (Although I suspect the kind of people who would be pleased to see a working prototype are also the kind of people who would listen to reason in the first place...) > I got a thorough chewing out for disrupting their processes Had that a few times. Been eased out of contracts for it too.
- titzer 7y agoIt's not clear from your comment which context you presented it in. It's definitely embarrassing for people to have this sprung on them unaware, especially presentation-style in a big room. You gotta show people stuff like this in private, 1-on-1, in a very casual "hey, what do you think of this little hack?" kind of way. People are a lot more receptive in that context, and if they have time to go away and mull over just how much time you could save them, and help them get done, they might actually like it. In short, don't embarrass your coworkers.
- tonyedgecombe 7y agoI don't think there is much you can do in these sort of situations. There is usually a layer of politics complicating things as well. Unless you are in a position to fire the team responsible then moving on is probably the best response.
- otterley 7y agoTo achieve a successful career, being good at navigating the complexities of people is often, if not more important than being good at navigating the complexities of code —- even in an engineering role.
- tonyedgecombe 7y agoYes, but where does that leave you. In an organisation that punishes productivity and initiative.
- kstrauser 7y agoFair point. I don't think I did it the crass way, but it's been quite a while and I'd tried to forget about the whole thing. I do remember showing it to a small group at first and getting the overall reaction of "but that's not the way we'd planned to do it!" > In short, don't embarrass your coworkers. This can't be overemphasized. And if you're in a situation where you have to decide between embarrassing your coworkers and going along with terrible ideas that waste time and money, then you may wish to decide to change part of the equation (e.g. removing yourself - or your coworkers - from the situation).