7 ms·
CuPy Accelerates NumPy on the GPU? Hold My Cider, Here's Clojure
- dragandj 7y agoUses free Clojure library Neanderthal: https://github.com/uncomplicate https://github.com/uncomplicate Also uses the book Numerical Linear Algebra for Programmers: https://aiprobook.com/numerical-linear-algebra-for-programmers https://aiprobook.com/numerical-linear-algebra-for-programme...
- akssri 7y agoThe benchmark is flawed. Cupy follows Numpy in doing a type-promotion of the data to float64 before computing the covariance. https://github.com/cupy/cupy/blob/b19577199d3f75c76e23c751941cb0976ce6ea01/cupy/statistics/correlation.py#L86 https://github.com/cupy/cupy/blob/b19577199d3f75c76e23c75194... The following function in PyTorch completes the float32 computation in 27 ms (1080 Ti). I'm fairly sure that a similar function in Cupy would achieve very similar results. def corr(dat): cov = (dat @ dat.T).div_(dat.shape[-1]-1) sigma = torch.diag(cov).sqrt_() return cov.div_(sigma[None]).div_(sigma[None].T) The heart of the computation SGEMM is in anycase provided by CUBLAS, and the only areas in which PyT and Cupy differ are in the tricks used to unroll the loop for the broadcasting & L1 op. The performance difference b/w PyT, Cupy and others should be negligible IMO. Note: np.corrcoef takes about 1.12 s and the above float32 version takes 325ms on the CPU.
- dragandj 7y agoSo, you first state that the benchmark is flawed, then you confirm the results of the benchmark, and repeat everything that the OP describes as the solution, just with a different tool (PyTorch instead of Clojure)? BTW did you check that your corr function gives the correct result? It looks to me that you forgot a few steps.
- akssri 7y agoThe PyT version above and the both the CPU/GPU versions on Neantherdal work completely in float32. I confirm that the performance of Neantherdal GPU is similar to that in the above PyT version. Yes. The part that is flawed is that you're comparing this to Numpy (CPU)/ Cupy (GPU) both of which coerce the input array to float64 (for precision reasons) before computing the covariance and correlation. You only need to check the output type of the result to verify this (if the pointer to the code is not sufficient).
- dragandj 7y agoWhat is flawed there? The point of the article is to show that CuPy very often does not accelerate NumPy, especially on consumer-grade hardware. This is something that most users of NumPy/CuPy do not know, and they are led by the docs to think it does. The reason for that is that CuPy is poorly implemented. And CuPy is poorly implemented because it is constrained by what NumPy does, which, in turn, does stuff that is OK on the CPU, and often translates poorly to the GPU.
- shezi 7y agoI didn't get that from the article at all. There was no "that's because..." or "you need to do this to make it fast..." in the article. Instead, it's "clojure is faster without additional work". While that's super neat and thank you for showing this, bashing python because the library doesn't automatically do that and then hiding behind this silly argument isn't that enlightening.
- dragandj 7y agoYou can check in the article that I made many checks to make sure that NumPy/CuPy get the data in float32. What do you suggest to do to instruct NumPy/CuPy to "automatically do that". Is there a way to say to python "I want you to use float32 precision for this computation" other than, well, providing everything as float32? And even if your argument stands, that does not change the fact that CuPy does not accelerate NumPy (in this particular case, but I'd say often).
- 7y ago
- jsdavo 7y agoThanks for sharing! Why does CuPy switch to float64 in this case? Is it a bug?
- akssri 7y agoNumpy/Cupy do explicit coercing to float64. There is no documentation for why this is done, but since GEMM is used to compute the covariates (summation over data points), it makes sense to increase the precision. You could get away using a double to only accumulate the sum, but it's a pain to write such mixed-precision (slow) function in C and then wrap it in Python, esp. for something like this. (See, https://github.com/numpy/numpy/blob/v1.17.0/numpy/lib/function_base.py#L2374 https://github.com/numpy/numpy/blob/v1.17.0/numpy/lib/functi...)
- fluffything 7y agoCuPy is a drop in replacement for NumPy. Ask Numpy why they do that.
- didibus 7y agoI'm not sure it is flawed. It just seems that you found the root cause of why NumPy/CuPy are slower, but it seems there is no way as a user of NumPy/CuPy to perform the float32 computation, even though you were explicit and said `:dtype "float32"`. All these libraries under the hood delegate to the same things for the actual computation, so the only advantage of one over the other would be this type of stuff. That NumPy/CuPy coerce to a float64 under the hood, and gives us no way to force it not to do so, is a disadvantage that they have in my opinion. In any case, like the article says, the performance of NumPy/CuPy is still good enough, and maybe NumPy thinks it knows better then it's users that they should be using higher precision always. Edit: I know I'll face the brigade of NumPy users. But I invite people to engage in the discussion unbiased. With a switch from CPU to GPU you'd expect more than 29% performance boost. If CuPy went with a float32 proc, it would give you a 96% performance increase! So ya, I think we can start to argue CuPy isn't doing the right thing here.
- akssri 7y ago> user of NumPy/CuPy to perform the float32 computation This is just getting tiring. Numpy and Cupy are perfectly capable of doing float32 computation - their only "fault" is that they coerce data to float64 in this one fairly unimportant function (which you can implement to your liking in 3-4 LOC). Hell, PFNs entire deep learning system, Chainer (which mind you, both predated and inspired PyTorch, and is still quite competitive with it), is built entirely on top of Cupy! Benchmarks make sense only when the outputs are the same - in this case, they certainly are not. It's the responsibility of the author to make sure that the outputs are the same (a real benchmark), or to argue that Numpy/Cupy are wasting time by using float64 in xp.cov (an issue of implementation). He does neither.
- didibus 7y ago> Numpy and Cupy are perfectly capable of doing float32 computation You're arguing that they would perfectly be capable of an implementation which would use float32, ya sure, if you change their source code you can have them be faster, that's an obvious to me? The question is, what kind of performance can you expect as a user using them as a library, and this benchmark is revealing of that in this case. What is wrong with it? It's like saying that you can change the implementation of Python and it will make Python code run faster, like sure you can, but you don't benchmark hypothetical future versions, the current version of CuPy uses float64 for this function, and that makes it that it barely runs faster then the CPU version. Point in case, I don't know what else you're trying to disagree about here. > their only fault is that they coerce data to float64 in this one fairly unimportant function I don't know that, all I know is when picking one function and benchmarking it, we found a flaw which result in performance gains from CPU to GPU to be extremely underwhelming. How many more if we started to benchmark the rest?
- xvilka 7y agoOr just use Julia where the speed is out of the box.
- bearzoo 7y agoOh? I don't suppose that julia wraps lapack functions for no good reason. What makes you say this
- ChrisRackauckas 7y agoA lot of the wrappers are largely legacy at this point. BLAS1 and BLAS2 operations are handled in pure Julia through the broadcast system, there's no performance degradation there and the fusion of operations actually makes for a lot of performance advantages over simple BLAS calls. For BLAS3, tools like LoopVectorization let you write a pure BLAS3 in Julia and get good performance, Gaius.jl is a good example of this by matching OpenBLAS with pure Julia code. Of course you still have to write out how to do blocking, but that's about it. At this point it's mostly needing more coverage before deprecating BLAS bindings in a Julia 2.0 down the line. https://github.com/MasonProtter/Gaius.jl https://github.com/MasonProtter/Gaius.jl
- bearzoo 7y agoThanks, that is pretty impressive
- eigenspace 7y agoI'm the dev of Gaius.jl. I'm not sure it will ever end up Julia's Base, but I think of it as a prototype implementation that might inspire (or possibly evolve into) a real implementation that could end up being bundled in the language eventually. Julia really does have the tools to solve this problem natively, and they're maturing quite a bit more quickly than I ever would have guessed a year ago. Last year if you had asked me I would have predicted the development of something like LoopVectorization.jl as appearing maybe by 2022 or something. Instead it's here now, albeit with a lot of work ahead to make it more robust.
- chenzhekl 7y agoCuPy is not developed by NVIDIA, but by Preferred Networks, the company behind Chainer.
- deleted 7y ago[deleted]
- rrss 7y ago> Power users even know that Nvidia provides a drop-in replacement, CuPy, that brings the power of GPU acceleration. > but Nvidia provides CuPy > It's Nvidia's stuff Is CuPy actually developed by Nvidia? It looks like the original authors were at Preferred Networks, and none of the top few contributors on github work at Nvidia.
- eslaught 7y agoIf anyone's looking for NumPy that works on distributed machines with GPUs, see also Legate, which is produced directly by NVIDIA: https://research.nvidia.com/publication/2019-11_Legate-NumPy%3A-Accelerated https://research.nvidia.com/publication/2019-11_Legate-NumPy... https://developer.nvidia.com/legate-early-access https://developer.nvidia.com/legate-early-access Disclaimer: I work on Legion, the runtime system that Legate sits on top of, but otherwise don't have anything to do with the Legate project.
- hellofunk 7y agoOne of the things I never understood about the hype around these Clojure GPU libraries is that there is a lot of marketing jumbo about how high-level it all is. Even the book for these libraries has the words "no C++!" half a dozen times on its ordering page [0]. However, these are just high-level libraries and you cannot write the GPU shaders in Clojure. You still must use C or C++ for that (depending on if you are going the CL or Cuda route), and your C/C++ code is embedded or called from the Clojure side. This is no different than using another high-level language like Python -- I mean it's focusing on a rather misleading and irrelevant detail. You can use Clojure or Python (or many other languages) to call OpenCL or Cuda shaders, or you can just use the libraries that call them for you. Clojure is not special in this regard. [0] https://aiprobook.com/deep-learning-for-programmers/ https://aiprobook.com/deep-learning-for-programmers/
- dragandj 7y agoThe book you've linked contains exactly 0 lines of C or C++ code. 100% of the code in the book is Clojure.
- didibus 7y agoHum.. I'm not sure there's that much hype. It's just saying that Clojure can also be used as a high level layer for fast linear algebra. I do see some claims that as a high level layer, Clojure works even better, it gives you a full REPL, and the power of macros and all that. It also goes to show you that there's barely any overhead added by the Clojure layer, which is something you want from a higher level layer. Maybe you need some additional context, but in the Clojure world, there are many offerings for that layering, core.matrix, neanderthal, NumPy, CuPy and others can all be used. So I guess a lot of what draganj is trying to show is he believes neanderthal is the layer with the least overhead, which everyone can agree to disagree on. You're never going to beat an assembly level implementation, or 50 year's worth of optimization done to a Fortran implementation, or straight openCL/cuda implementation in a higher level language, especially not in Clojure. So in the market of high level languages like Julia, Clojure, Python, R, Swift, etc. and their corresponding libraries, they all are just competing on being more user friendly, having better more useful/flexible abstractions, a better development flow, and the least amount of overhead. So that's what you'll be hearing them all fight over.
- bernardv 7y agoGreat article. I learned a bunch of things I didn’t know about Numpy and Clojure. As far as I’m concerned the Dragan does rock.