4 ms·
I really love you have picked up from skeleton / milligram. A suggestion, you might want to included a minified version of the css because it looks to be 22kb
by alberth 7y ago
I really love you have picked up from skeleton / milligram.
A suggestion, you might want to included a minified version of the css because it looks to be 22kb and you’ll be compared against skeleton which is just 2kb.
https://github.com/robsheldon/sscaffold-css/blob/master/sscaffold.css https://github.com/robsheldon/sscaffold-css/blob/master/ssca...
Edit: typo
- e12e 7y agoIf the idea is to edit the single file, rather than include it and an override - would it make sense to distribute a minified version? Also, what's the difference after gzip/deflate?
- alberth 7y agoIsn’t the best approach to frameworks always been to “include it and override it” that way your customizations stay cleanly separate and upgrading the framework is just a drop in replacement.
- thaumaturgy 7y agoFWIW I want this to work for both of you. I wanted the single file to be a good enough drop-in to get a project started, but I also reorganized the CSS to make it easier to override it for custom theming. There should be a minified version too.
- e12e 7y ago> also reorganized the CSS to make it easier to override it I think this could/should be made more clear on the homeppage. I generally prefer cascading styles (base+override) - but for that to work well, especially with bug fixes to the underlying library/framework - the CSS needs to be well structured. I'm a little amazed that the theming story for earlier versions of bootstrap is so horrible, for example (although, part of that is due to terrible "theme packs" by people that don't understand CSS, or bootstrap).
- hanniabu 7y agoUnrelated: What's the reason for mentioning an edit for a typo? As far as I can tell there's no indication that your comment has been edited so nobody would know, unless I don't have enough karma to see this indication or something?
- iudqnolq 7y agoIt's convention to be extremely transparent about edits because of irritation with people who change their comments after being replied to, making the replies look irrelevant or incorrect. The only way for people to know about an edit is to see that comment changing. Sometimes you'll see allegations posted about surreptitious comment editing. It's just easier to always say you've edited.
- hanniabu 7y agoI understand that, but was curious about typo edits in particular. A typo fix doesn't change the meaning of the comment in 99% of cases.