3 ms·

No mention of providing positive comments? e.g. "Very readable. I think this abstraction will save us a lot of time in the future too.". It's tiring to work day

No mention of providing positive comments? e.g. "Very readable. I think this abstraction will save us a lot of time in the future too.". It's tiring to work days on a commit only to get a bunch of fixes back with no understanding of what people consider good tradeoffs and high quality for future commits.

Aeolun 7y ago
And then your commit is merged, and all your great code is going to be used. While I understand wanting to be praised to some extend, wanting to be praised for doing your job still sounds a bit off to me. That said, getting multiple rounds of fixes bothers me to no end, so I guess it’s always merge after the first round of fixes.
- seanwilson 7y ago
  > And then your commit is merged, and all your great code is going to be used. It's more about understanding what qualities in your code your team appreciates. There's a big spectrum in code that gets accepted for being amazing and code that only gets barely accepted too. > While I understand wanting to be praised to some extend, wanting to be praised for doing your job still sounds a bit off to me. Do you think it's weird that people in other industries might say "great work!" from time to time? Seems like a basic part of social interaction to me. I don't want to work with robots, especially the people in code review discussions that say everyone should just have a thicker skin. Only getting negative comments back from people and "pull request accepted" notifications is a cold environment to work in, especially if you work remote.
  - Aeolun 7y ago
    > Do you think it's weird that people in other industries might say "great work!" from time to time? Not at all, it’s just that I personally don’t say, or expect, a “good work” message unless I’m honestly impressed by what was written. I’ve received that once or twice, and given it a few more times (in 10 years). But just saying good work to keep someone’s motivation up, that is something I would have to consciously think about.

Aeolun 7y ago

And then your commit is merged, and all your great code is going to be used. While I understand wanting to be praised to some extend, wanting to be praised for doing your job still sounds a bit off to me. That said, getting multiple rounds of fixes bothers me to no end, so I guess it’s always merge after the first round of fixes.

seanwilson 7y ago
> And then your commit is merged, and all your great code is going to be used. It's more about understanding what qualities in your code your team appreciates. There's a big spectrum in code that gets accepted for being amazing and code that only gets barely accepted too. > While I understand wanting to be praised to some extend, wanting to be praised for doing your job still sounds a bit off to me. Do you think it's weird that people in other industries might say "great work!" from time to time? Seems like a basic part of social interaction to me. I don't want to work with robots, especially the people in code review discussions that say everyone should just have a thicker skin. Only getting negative comments back from people and "pull request accepted" notifications is a cold environment to work in, especially if you work remote.
- Aeolun 7y ago
  > Do you think it's weird that people in other industries might say "great work!" from time to time? Not at all, it’s just that I personally don’t say, or expect, a “good work” message unless I’m honestly impressed by what was written. I’ve received that once or twice, and given it a few more times (in 10 years). But just saying good work to keep someone’s motivation up, that is something I would have to consciously think about.