3 ms·
Code review comments at google attach to a region rather than a specific line.
by im3w1l 7y ago
Code review comments at google attach to a region rather than a specific line.
- raxxorrax 7y agoReally? isn't that impractical? I think you should be mindful of the context, but I would believe this to be a hindrance if I want to discuss specifics. Or is this a mechanism precisely to not get lost in details?
- adrianmonk 7y agoI think they mean if your comment refers to lines 310 to 313, you can explicitly specify that range instead of having to arbitrarily select 310 and let the reader infer that you mean the following lines too. (On a side note, I'd observe you may not be able to rely on reviewers consistently and accurately specifying the exact range they mean. It would be like assuming that nobody makes spelling errors in emails.)