3 ms·
The problem I would have is that it is too vague. What do you not understand about it? Usually there's more than one point you could be confused on. For exampl
by adrianmonk 7y ago
The problem I would have is that it is too vague. What do you not understand about it? Usually there's more than one point you could be confused on.
For example, let's say I'm using a hash to eliminate duplicate strings when building a message to send over the network. Do you not understand how duplicates could occur in the first place? Do you not understand why I'm using a hash instead of some other implementation choice? Or do you not understand why duplicates cannot be put into the message I'm building?
In other words, when you say "I don't understand this", is it clear and unambiguous what "this" refers to?
Sometimes the line number you choose to put your comment on makes it pretty clear. But not always. You might have a problem with that line, or you might have a problem with a chunk of code that begins at that line.
- im3w1l 7y agoCode review comments at google attach to a region rather than a specific line.
- raxxorrax 7y agoReally? isn't that impractical? I think you should be mindful of the context, but I would believe this to be a hindrance if I want to discuss specifics. Or is this a mechanism precisely to not get lost in details?
- adrianmonk 7y agoI think they mean if your comment refers to lines 310 to 313, you can explicitly specify that range instead of having to arbitrarily select 310 and let the reader infer that you mean the following lines too. (On a side note, I'd observe you may not be able to rely on reviewers consistently and accurately specifying the exact range they mean. It would be like assuming that nobody makes spelling errors in emails.)