3 ms·

I used `async` as the name of a function decorator in some Python3.4 code, which then broke in 3.6 which introduced `async` as a keyword.

• zerkten 7y ago
  What was the level of effort to remediate that?
  • takeda 7y ago
    sed 's/async/whatever' ...
  • rabidrat 7y ago
    Probably around 4-6 hours of work all told. We had to come up with a new name, do a find/replace, review the changes, test, fix a couple of issues because the replace wasn't perfect/complete, update the dev documentation, make a new patch release, and then create packages for the various supported platforms. Oh and looking back over it now, the filename had to be changed too, because apparently you can't use a keyword as a module name in Python either. So where the documentation linked directly to that file, that had to be updated as well. [1] https://github.com/saulpw/visidata/issues/164 https://github.com/saulpw/visidata/issues/164 [2] https://github.com/saulpw/visidata/releases/tag/v1.2.1 https://github.com/saulpw/visidata/releases/tag/v1.2.1