3 ms·

This is the commit containing the code that Elastic says was copied by Search Guard: https://github.com/floragunncom/search-guard-enterprise-modules/commit/93b

This is the commit containing the code that Elastic says was copied by Search Guard: https://github.com/floragunncom/search-guard-enterprise-modules/commit/93b491a182c2f8ff4d0b7ac72cb4bda0c6eb12d2 https://github.com/floragunncom/search-guard-enterprise-modu... In particular, the change to getLiveDocs(): https://github.com/floragunncom/search-guard-enterprise-modules/commit/93b491a182c2f8ff4d0b7ac72cb4bda0c6eb12d2#diff-1e087c32ad166566456e9a43991a57caR407-R429 https://github.com/floragunncom/search-guard-enterprise-modu... and numDocs(): https://github.com/floragunncom/search-guard-enterprise-modules/commit/93b491a182c2f8ff4d0b7ac72cb4bda0c6eb12d2#diff-1e087c32ad166566456e9a43991a57caR437-R469 https://github.com/floragunncom/search-guard-enterprise-modu... EDIT: At least in the case of numDocs(), both Elastic and Search Guard's implementations seem to be based on this bit of Apache-licensed code from Lucene (or perhaps this is just a common pattern for counting live documents?): https://github.com/apache/lucene-solr/blob/branch_6_3/lucene/misc/src/java/org/apache/lucene/index/PKIndexSplitter.java#L146-L158 https://github.com/apache/lucene-solr/blob/branch_6_3/lucene...

throwarayes 7y ago
Doesn't appear to be earth shattering changes. In fact it looks pretty boilerplate. As someone who maintains an Elasticsearch plugin, you often have to do A LOT of research into how Elastic themselves have dealt with their undocumented, constantly evolving APIs to figure out how to adapt your own code. Stuff like this happens all the time where some boilerplate code changes, you copy in the way Elastic themselves did it. Given how the code is now a mix of Elastic and Apache code, now you can create a host of legal liability by accidentally taking the wrong piece of boilerplate. Potential legal liability on top the headaches of maintaining an open source project in my spare time with almost no support. Oh joy.
- dragonsh 7y ago
  I am not sure every comment critical of elastic's move has been down voted consistently to grey them out. This has happened with my comments on other posts, it's content is that instead of using license encumbered ELK product people can use SOLR, Vespa or Lucene which are truly open source. It was down voted enough to move it to last or grey it out to make it difficult to read.
  - thayne 7y ago
    solr, vespa, and lucene only replace the elasticsearch part of ELk. Fluentd is an obvious replacment for Logstash, but I'm not sure what a good open source alternative to Kibana is that is compatible with solr, vespa, or lucene.
    - dragonsh 7y ago
      Grafana comes to mind as kibana replacement.
      - thayne 7y ago
        My understanding is that grafana is good at visualization, not searching for specific events.
        nopzor 7y ago
        this is changing as grafana evolves to move into logs in addition to metrics
        thayne 7y ago
        Interesting, however it doesn't seem like it is a full replacement, since it doesn't do full text indexing: > Loki is meant to be complementary to existing solutions like Elasticsearch and Splunk that do full text indexing.
    - contol-m 7y ago
      Lucene is a low level library which is internally used by ElasticSearch and Solr. Vespa is built from the ground up - it does not use Lucene.

throwarayes 7y ago

Doesn't appear to be earth shattering changes. In fact it looks pretty boilerplate. As someone who maintains an Elasticsearch plugin, you often have to do A LOT of research into how Elastic themselves have dealt with their undocumented, constantly evolving APIs to figure out how to adapt your own code. Stuff like this happens all the time where some boilerplate code changes, you copy in the way Elastic themselves did it. Given how the code is now a mix of Elastic and Apache code, now you can create a host of legal liability by accidentally taking the wrong piece of boilerplate. Potential legal liability on top the headaches of maintaining an open source project in my spare time with almost no support. Oh joy.

dragonsh 7y ago
I am not sure every comment critical of elastic's move has been down voted consistently to grey them out. This has happened with my comments on other posts, it's content is that instead of using license encumbered ELK product people can use SOLR, Vespa or Lucene which are truly open source. It was down voted enough to move it to last or grey it out to make it difficult to read.
- thayne 7y ago
  solr, vespa, and lucene only replace the elasticsearch part of ELk. Fluentd is an obvious replacment for Logstash, but I'm not sure what a good open source alternative to Kibana is that is compatible with solr, vespa, or lucene.
  - dragonsh 7y ago
    Grafana comes to mind as kibana replacement.
    - thayne 7y ago
      My understanding is that grafana is good at visualization, not searching for specific events.
      - nopzor 7y ago
        this is changing as grafana evolves to move into logs in addition to metrics
        thayne 7y ago
        Interesting, however it doesn't seem like it is a full replacement, since it doesn't do full text indexing: > Loki is meant to be complementary to existing solutions like Elasticsearch and Splunk that do full text indexing.
  - contol-m 7y ago
    Lucene is a low level library which is internally used by ElasticSearch and Solr. Vespa is built from the ground up - it does not use Lucene.