3 ms·
I realise that some of the contributors to the documentation here may not be native English speakers, and if so, I would encourage them to clean up the English.
by wyclif 8y ago
I realise that some of the contributors to the documentation here may not be native English speakers, and if so, I would encourage them to clean up the English.
- makepanic 8y agoIf you found typos or issues with the docs, why not open a PR and fix it? https://github.com/SpaceVim/SpaceVim/blob/master/docs/_posts/2019-04-08-SpaceVim-release-v1.1.0.md https://github.com/SpaceVim/SpaceVim/blob/master/docs/_posts...
- krageon 8y agoWhile you make a good point that pull requests can be made because it is open-source, I've always found the "pull requests welcome" response to a (presumably good faith) piece of constructive criticism as a little dismissive.
- craftyguy 8y agoOr, it literally means, "we don't know what you found, so please point it out." Not every response for help is a "fork off."
- ahaferburg 8y agoBecause I'd have to fork, wait for the Github client to process the fork, find the source file that produced the error, fix it, commit, push, then go back to Github to create a PR. PRs are overkill for typos on a project I don't develop on.
- arthurk 8y agoYou can do all of this from the web interface. There's a pencil icon on the top right of the document. It will let you edit the file then create a fork and PR
- ahaferburg 8y agoAwesome, didn't know that. Thanks!
- beatgammit 8y agoIt's relatively new and fantastic for simple text edits, though I certainly would recommend actually testing changes if you're changing code.