4 ms·
Thanks for the feedback! >Icons should be used to help clarify things, but most of the icons seem to be just arrows pointing right on links. You can probably o
by Sir_Cmpwn 8y ago
Thanks for the feedback!
>Icons should be used to help clarify things, but most of the icons seem to be just arrows pointing right on links. You can probably omit them!
I discussed my opinion on icons in the article, and I stand by it in this case.
> the source tree, I had no idea I could click on the file names until I hovered over them by chance. Blue text alongside black text is a very strong signal that the blue text is a link and the black text is not. (Also note that in the file path at the top, the ancestor directories are blue and clickable while the current directory is black and not). Here is where an icon would be useful: to disambiguate between directories and files.
Good point. I don't want to add an icon, but I should make filenames underlined or something like that.
>for whatever reason, keyboard navigation doesn't work for me in Firefox.
That's bizarre, it works fine for me. Can anyone else reproduce this?
- jakelazaroff 8y agoRe: icons, sorry if I was unclear — I'm not suggesting you add more icons, and I think your opinion in the article is good! I'm saying that it's not obvious to me what the right arrow means specifically, and (IMO) it's common enough that it adds visual clutter. For example, in the tree summary, "browse" and "log" have the right arrow, but the repo URL under "read-only" doesn't, and it's not clear why.
- isthisnagee 8y agoI can reproduce it. I'm on Firefox Developer Edition, 66.0b9. I went to https://meta.sr.ht/ https://meta.sr.ht/ and tried to tab through the site. Here's a gif: https://i.imgur.com/2dQL2C2.gif https://i.imgur.com/2dQL2C2.gif. Explanation of gif: I clicked on the search bar, then clicked on the site, then pressed tab repeatedly.
- Sir_Cmpwn 8y agoThis is totally bizarre. I think it's a Firefox bug. Can you open a ticket on Firefox's bugzilla?
- isthisnagee 8y agoDone: https://webcompat.com/issues/27204 https://webcompat.com/issues/27204
- Sir_Cmpwn 8y agoThis... is not the Firefox bugzilla.
- isthisnagee 8y agohttps://bugzilla.mozilla.org/ https://bugzilla.mozilla.org/ > New Bug > Report an issue with a website that I use Seemed like the most appropriate place to put it.
- Sir_Cmpwn 8y agoFair enough, I didn't realize that was a Mozilla thing.