3 ms·
Reading another human's code (or prose) is the closest thing we have to mind reading. Whenever I can't avoid doing code reviews, most often, I really wish I did
by specialist 8y ago
Reading another human's code (or prose) is the closest thing we have to mind reading. Whenever I can't avoid doing code reviews, most often, I really wish I didn't know that much about the author.
--
"...code must act as a teacher..."
Agree. Alas, most teachers aren't very good.
https://en.wikipedia.org/wiki/Sturgeon's_law https://en.wikipedia.org/wiki/Sturgeon's_law
I used to really care about this stuff. I started a design pattern study group 25 (?) years ago. It's still going strong. (Geeks love to eat pizza and argue about the rules. :) )
Professionally, I've all but given up. Any more, I just try to mimic the code style of whatever goo I'm working on. And do whatever kabuki required of me to get my PRs merged.
Programming is now my hobby. Whenever I feel the need to code with intent and feeling, I work on a personal project. (For some reason, this reminds me of Al Pacino quote about exercising. Something like "I just lie down until the feeling goes away." Happily, I'm not that bleak.)
--
When I am feeling optimistic, I imagine a future where we adopt a hybrid of Pieter Hintjens' Social Architecture and Michael Bryzek's Test in Production.
https://legacy.gitbook.com/book/hintjens/social-architecture/details https://legacy.gitbook.com/book/hintjens/social-architecture...
https://qconsf.com/sf2017/sf2017/presentation/testing-production-quality-software-faster.html https://qconsf.com/sf2017/sf2017/presentation/testing-produc...
TL;DR: Accept all PRs, radically reduce the cost of changes.
- Aeolun 8y agoI think I mostly accept anything that comes my way, except for ones that have obvious, non-blocking fixes. People tell me to be more critical, but there’s no point in holding everything up because someone wrote a triple nested ternary operator. It’s icky, but they, or someone else, will fix it the next time they come across that piece of code. That’s why we have tests.