6 ms·
For mine every feat/fix/refactor is a new branch which then requires 2 approvals to get merged, among other things (style guide enforced as linting, minimum tes
by kace91 8y ago
For mine every feat/fix/refactor is a new branch which then requires 2 approvals to get merged, among other things (style guide enforced as linting, minimum test coverage threshold, etc ).
Tbh it's cool, coming from a previous job at a startup where version control meant just zipping the project from time to time.
- jimwalsh 8y agoThis is what happens where I work as well.
- ff_ 8y agoSame here. All code goes in a Pull Request, and requires at least 1 approval. Since Pull Request review is a high priority activity there's no "bottleneck", and you double the bus factor for free + prevent bad things from happening.
- rich-w-big-ego 8y agoYeah but you can still push commits to a PR that has received approval, and the approval is not revoked.