4 ms·

I imagine this would break many JS-y websites? Since just swapping in the body means that you'll lose assertions about init code only running once

by rtpg 9y ago

lettergram 9y ago
From a background using turbolinks extensively, if you do: $(document).on('turbolinks:load', insertFunctionHere); Then you should be good to go in terms of loading functions after the trubolink(s). There should be a way to reverse this for this application. I personally, don't know -_-
amelius 9y ago
Okay, how do we protect against this problem? It would be nice to have a piece of code that detects the problem and shows a message "Hey, you have a browser extension that is not playing nice with this website; please turn the extension off". What would that piece of code look like?
- bastawhiz 9y ago
  I don't think we should do anything. As a front-end guy myself, it's silly to have to add a bunch of code to check for all the nonsensical browser extensions that could break my page. If a user wants to use a broken extension, please be my guest, but don't think I'm going to go out of my way (and increase my bundle size) to warn you that you've got your footgun locked and loaded. Hell, there are already enough problems with working around naive ad blockers (images being blocked because they have their dimensions listed in the file name, `class="ad"` being hard blocked, etc). At least those extensions are popular enough to matter and break fairly infrequently.
  - always_good 9y ago
    Reminds me of when I was generating uuids for user-uploaded avatars and putting them in url buckets like `/fc/cdcabe...`. Of course, I would eventually have to track down why some images weren't loading for a lot of users. Took me a moment to notice the `/ad/...`.
  - deleted 9y ago
    [deleted]
jajoosam 9y ago
I've started work on a blacklist- https://github.com/jajoosam/fastr/issues/3 https://github.com/jajoosam/fastr/issues/3 Please contribute with any sites which fastr has broken.

I imagine this would break many JS-y websites? Since just swapping in the body means that you'll lose assertions about init code only running once

by rtpg 9y ago

I imagine this would break many JS-y websites? Since just swapping in the body means that you'll lose assertions about init code only running once

lettergram 9y ago

From a background using turbolinks extensively, if you do: $(document).on('turbolinks:load', insertFunctionHere); Then you should be good to go in terms of loading functions after the trubolink(s). There should be a way to reverse this for this application. I personally, don't know -_-

amelius 9y ago

Okay, how do we protect against this problem? It would be nice to have a piece of code that detects the problem and shows a message "Hey, you have a browser extension that is not playing nice with this website; please turn the extension off". What would that piece of code look like?

bastawhiz 9y ago
I don't think we should do anything. As a front-end guy myself, it's silly to have to add a bunch of code to check for all the nonsensical browser extensions that could break my page. If a user wants to use a broken extension, please be my guest, but don't think I'm going to go out of my way (and increase my bundle size) to warn you that you've got your footgun locked and loaded. Hell, there are already enough problems with working around naive ad blockers (images being blocked because they have their dimensions listed in the file name, `class="ad"` being hard blocked, etc). At least those extensions are popular enough to matter and break fairly infrequently.
- always_good 9y ago
  Reminds me of when I was generating uuids for user-uploaded avatars and putting them in url buckets like `/fc/cdcabe...`. Of course, I would eventually have to track down why some images weren't loading for a lot of users. Took me a moment to notice the `/ad/...`.
- deleted 9y ago
  [deleted]

jajoosam 9y ago

I've started work on a blacklist- https://github.com/jajoosam/fastr/issues/3 https://github.com/jajoosam/fastr/issues/3 Please contribute with any sites which fastr has broken.