3 ms·

This means code review process is completely wrong. All these "nitpicks" should be automated by linters and code review should be more about implementation, str

• auggierose 9y ago
  But some people just cant help themselves. They are natural nitpickers and this process just enables them ...
• geocar 9y ago
  Yes, it does mean that code review is completely wrong. If you read the article, they suggest strongly that it is hard to get a "correct" code review process (perhaps because it encourages the nitpickers, or perhaps for other reasons). If you've got a bunch of experienced people spending a year on it that can't solve it, perhaps they just can't solve it. And at that point: What's the difference between something that's wrong, and something that they can't do right?
• watwut 9y ago
  Most review processes are wrong. Sometimes because it rubber stamp everything, other times because the most aggressive one is not the most knowledgeable one and yet other times cause they turn into competition of who is more petty. Good code review is hard. Catching non petty problems is much harder then lengthy obsessing over function names or 'if' vs '?' or whether slightly more or slightly less abstraction or whether two 6 line long function vs one 12 lines long.