4 ms·

I would think it's a sensible default, but you're right, you should have the option to change it. I actually assumed the option was there, but I just checked in

I would think it's a sensible default, but you're right, you should have the option to change it. I actually assumed the option was there, but I just checked in 9.3, and it's not.

sytse 9y ago
I'm sorry to hear it caused problems. I think we can maybe make the behavior more intelligent, it should not delete longer running branches by default. We are very reluctant to add options to GitLab as detailed in point 11 of the acceptance criteria of our contributing guide https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBU... But if we can't make the behavior more intelligent we will probably have to add an option.
- Aeolun 9y ago
  To give a different perspective. I always forgot to check the box, and now noticed a significant decrease in randomly left over branches. So it's working out pretty well for me.
  - slavik81 9y ago
    It seems like it would be possible to have the best of both worlds by defaulting to checked for first PR from a branch, but defaulting to unchecked for subsequent PRs from the same branch (because if you didn't delete it last time, you probably don't want to delete it this time).
- mweibel 9y ago
  I think it's not bad to have it checked by default but a bit more intelligent it surely can be. The biggest annoyance and source of confusion is when you make a merge request based on a protected branch. The checkbox is still there and checked but it won't actually delete the protected branch (well, that's good ;-)). In that case the checkbox should just be not displayed at all.
  - lloeki 9y ago
    Or rather, displayed but disabled with a message explaining why it can't/won't be used.
    - Snappy 9y ago
      Great suggestion, thanks! Created https://gitlab.com/gitlab-org/gitlab-ce/issues/34248 https://gitlab.com/gitlab-org/gitlab-ce/issues/34248 to track.

I would think it's a sensible default, but you're right, you should have the option to change it. I actually assumed the option was there, but I just checked in 9.3, and it's not.

sytse 9y ago

I'm sorry to hear it caused problems. I think we can maybe make the behavior more intelligent, it should not delete longer running branches by default. We are very reluctant to add options to GitLab as detailed in point 11 of the acceptance criteria of our contributing guide https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBU... But if we can't make the behavior more intelligent we will probably have to add an option.

Aeolun 9y ago
To give a different perspective. I always forgot to check the box, and now noticed a significant decrease in randomly left over branches. So it's working out pretty well for me.
- slavik81 9y ago
  It seems like it would be possible to have the best of both worlds by defaulting to checked for first PR from a branch, but defaulting to unchecked for subsequent PRs from the same branch (because if you didn't delete it last time, you probably don't want to delete it this time).
mweibel 9y ago
I think it's not bad to have it checked by default but a bit more intelligent it surely can be. The biggest annoyance and source of confusion is when you make a merge request based on a protected branch. The checkbox is still there and checked but it won't actually delete the protected branch (well, that's good ;-)). In that case the checkbox should just be not displayed at all.
- lloeki 9y ago
  Or rather, displayed but disabled with a message explaining why it can't/won't be used.
  - Snappy 9y ago
    Great suggestion, thanks! Created https://gitlab.com/gitlab-org/gitlab-ce/issues/34248 https://gitlab.com/gitlab-org/gitlab-ce/issues/34248 to track.