4 ms·

The library in question would be uWebSockets? https://github.com/uWebSockets/uWebSockets https://github.com/uWebSockets/uWebSockets

• TheDong 9y ago
  If so, that's the zlib license, which requires no acknowledgement for binary distributions. If they distributed the sourcecode, they'd have to include the license, but the zlib license has nothing to say about compiling it in.
  • deleted 9y ago
    [deleted]
  • alexhultman 9y ago
    They are distributing both binary (no problem here) and source (problem).
    • charlesdm 9y ago
      Maybe I'm an idiot, but I don't see any problems? —————————— Copyright (c) 2016 Alex Hultman and contributors This software is provided 'as-is', without any express or implied warranty. In no event will the authors be held liable for any damages arising from the use of this software. Permission is granted to anyone to use this software for any purpose, including commercial applications, and to alter it and redistribute it freely, subject to the following restrictions: 1. The origin of this software must not be misrepresented; you must not claim that you wrote the original software. If you use this software in a product, an acknowledgement in the product documentation would be appreciated but is not required. 2. Altered source versions must be plainly marked as such, and must not be misrepresented as being the original software. 3. This notice may not be removed or altered from any source distribution. —————————— a) This software is provided ‘as-is’, and as the author, you are not liable for damages if someone uses your library for something crazy. b) Anyone can freely use it, for any purpose, with following restrictions: 1. “If you use this software in a product, an acknowledgement in the product documentation would be appreciated but is not required.”. They decided not to acknowledge the use of your library. You explicitly said this is OK. 2. Altered source code -> probably not.. it’s a web socket handling library. 3. This notice may not be removed. They have probably not removed it from their source code, given they distribute a binary.
      • alexhultman 9y ago
        Can you find this notice in their distribution? I have looked in their client UI and in their client tar.gz but I cannot find anything. I can however easily find my project in there (I would think the license would be nicely placed where the sources are).
        • packetized 9y ago
          Can you share where you found the project files in the client tar.gz? edit: Found it, uws.js in resources/bootstrap/discord_rpc.zip edit2: This is arguably worse, but the argument may be "it's a compiled binary": -bash-4.1$ strings discord_rpc.node | grep uws.*cpp$ ../../discord_common/native/third_party/uws/nodejs/addon.cpp ../../discord_common/native/third_party/uws/nodejs/addon.cpp ../../discord_common/native/third_party/uws/src/EventSystem.cpp ../../discord_common/native/third_party/uws/src/Extensions.cpp ../../discord_common/native/third_party/uws/src/HTTPSocket.cpp ../../discord_common/native/third_party/uws/src/Network.cpp ../../discord_common/native/third_party/uws/src/Server.cpp ../../discord_common/native/third_party/uws/src/UTF8.cpp ../../discord_common/native/third_party/uws/src/WebSocket.cpp ../../discord_common/native/third_party/uws/nodejs/addon.cpp ../../discord_common/native/third_party/uws/src/HTTPSocket.cpp ../../discord_common/native/third_party/uws/src/WebSocket.cpp ../../discord_common/native/third_party/uws/src/EventSystem.cpp ../../discord_common/native/third_party/uws/src/Extensions.cpp ../../discord_common/native/third_party/uws/src/Network.cpp ../../discord_common/native/third_party/uws/src/Server.cpp ../../discord_common/native/third_party/uws/src/UTF8.cpp -bash-4.1$
          • dsp1234 9y ago
            Which must be doubly frustrating since they have a copy of https://github.com/websockets/ws https://github.com/websockets/ws in the node_modules folder, and that has the appropriate license text (MIT in that case)
          • charlesdm 9y ago
            If it's compiled, they don't need to add anything. If it's interpreted, i.e. a JS file, they do (at the top of the JS file)
    • deleted 9y ago
      [deleted]