3 ms·

Better look at commits. I am not familiar with their code base, but latest commit seems like a bugfix: https://github.com/zcoinofficial/zcoin/commit/33796c839f

Better look at commits. I am not familiar with their code base, but latest commit seems like a bugfix: https://github.com/zcoinofficial/zcoin/commit/33796c839f7d4df4fb89c2775ec971982cfc8996 https://github.com/zcoinofficial/zcoin/commit/33796c839f7d4d...

gukov 10y ago
Looks like they replaced a 50 with a 100.
notimetorelax 10y ago
So... were's a unit test to make sure this never happens again?
- edsouza 10y ago
  I rather actually see a real comment if there is no time to create a unit test. Why does changing ZQ_PEDERSEN to ZQ_WILLIAMSON fix the bug? Having meaningful named constants would make much more sense. Edit: On full view of the code, the bug could be avoid if they broke out the if <demoninationX> blocks into their own function, and to prevent "typo" errors, it would be good to have a local variable named current_demoniation = demoniationX, and then reference that local variable instead of referencing the constant everytime.
  - Rangi42 10y ago
    Apparently those are names for 50 and 100 BTC. From this presentation[1] or the source code[2]: 1 Lovelace = 1 Bitcoin 1 Goldwasser = 10 Bitcoin 1 Rackoff = 25 Bitcoin 1 Pedersen = 50 Bitcoin 1 Williamson = 100 Bitcoin But yes, those are meaningless names in themselves. Metric prefixes like "hectobitcoin" would be better. [1]: https://sar.informatik.hu-berlin.de/teaching/2013-w/2013-w%20Electronic%20Identity/slides/Anonymit%C3%A4t_in_Bitcoin_.pdf https://sar.informatik.hu-berlin.de/teaching/2013-w/2013-w%2... [2]: https://github.com/Zerocoin/libzerocoin/blob/master/Coin.h#L19-L27 https://github.com/Zerocoin/libzerocoin/blob/master/Coin.h#L...
w-ll 10y ago
Actually I think this might have been the fix. https://github.com/zcoinofficial/zcoin/commit/584e1c60617d59b3b250a71f622ff135e172d750 https://github.com/zcoinofficial/zcoin/commit/584e1c60617d59...
- emmelaich 10y ago
  Nope this -- 4 commits later, and 12 minutes ago at this time. https://github.com/zcoinofficial/zcoin/commit/b20c177032de3c4bfae62b5ada768a5dc2b4fa67 https://github.com/zcoinofficial/zcoin/commit/b20c177032de3c...

gukov 10y ago

Looks like they replaced a 50 with a 100.

notimetorelax 10y ago

So... were's a unit test to make sure this never happens again?

edsouza 10y ago
I rather actually see a real comment if there is no time to create a unit test. Why does changing ZQ_PEDERSEN to ZQ_WILLIAMSON fix the bug? Having meaningful named constants would make much more sense. Edit: On full view of the code, the bug could be avoid if they broke out the if <demoninationX> blocks into their own function, and to prevent "typo" errors, it would be good to have a local variable named current_demoniation = demoniationX, and then reference that local variable instead of referencing the constant everytime.
- Rangi42 10y ago
  Apparently those are names for 50 and 100 BTC. From this presentation[1] or the source code[2]: 1 Lovelace = 1 Bitcoin 1 Goldwasser = 10 Bitcoin 1 Rackoff = 25 Bitcoin 1 Pedersen = 50 Bitcoin 1 Williamson = 100 Bitcoin But yes, those are meaningless names in themselves. Metric prefixes like "hectobitcoin" would be better. [1]: https://sar.informatik.hu-berlin.de/teaching/2013-w/2013-w%20Electronic%20Identity/slides/Anonymit%C3%A4t_in_Bitcoin_.pdf https://sar.informatik.hu-berlin.de/teaching/2013-w/2013-w%2... [2]: https://github.com/Zerocoin/libzerocoin/blob/master/Coin.h#L19-L27 https://github.com/Zerocoin/libzerocoin/blob/master/Coin.h#L...

w-ll 10y ago

Actually I think this might have been the fix. https://github.com/zcoinofficial/zcoin/commit/584e1c60617d59b3b250a71f622ff135e172d750 https://github.com/zcoinofficial/zcoin/commit/584e1c60617d59...

emmelaich 10y ago
Nope this -- 4 commits later, and 12 minutes ago at this time. https://github.com/zcoinofficial/zcoin/commit/b20c177032de3c4bfae62b5ada768a5dc2b4fa67 https://github.com/zcoinofficial/zcoin/commit/b20c177032de3c...